Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/FilterEngine.cpp

Issue 4899447913840640: Issue 1106 - Add currentVersion Pref and compareVersions API (Closed)
Patch Set: Created Aug. 1, 2014, 12:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/prefs.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 { 327 {
328 jsEngine->RemoveEventCallback("filterChange"); 328 jsEngine->RemoveEventCallback("filterChange");
329 } 329 }
330 330
331 void FilterEngine::FilterChanged(FilterEngine::FilterChangeCallback callback, Js ValueList& params) 331 void FilterEngine::FilterChanged(FilterEngine::FilterChangeCallback callback, Js ValueList& params)
332 { 332 {
333 std::string action(params.size() >= 1 && !params[0]->IsNull() ? params[0]->AsS tring() : ""); 333 std::string action(params.size() >= 1 && !params[0]->IsNull() ? params[0]->AsS tring() : "");
334 JsValuePtr item(params.size() >= 2 ? params[1] : jsEngine->NewValue(false)); 334 JsValuePtr item(params.size() >= 2 ? params[1] : jsEngine->NewValue(false));
335 callback(action, item); 335 callback(action, item);
336 } 336 }
337
338 int FilterEngine::CompareVersions(const std::string& v1, const std::string& v2)
339 {
340 JsValueList params;
341 params.push_back(jsEngine->NewValue(v1));
342 params.push_back(jsEngine->NewValue(v2));
343 JsValuePtr func = jsEngine->Evaluate("API.compareVersions");
344 return func->Call(params)->AsInt();
345 }
OLDNEW
« no previous file with comments | « lib/prefs.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld