Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/Notification.cpp

Issue 4904655779790848: Issue 1107.update1 - read Notification properties (title, message and type) on the fly (Closed)
Left Patch Set: Created Jan. 27, 2015, 10:15 a.m.
Right Patch Set: rebase Created Nov. 4, 2015, 9:22 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/FilterEngine.cpp ('k') | test/Notification.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 notificationTexts.title = jsTitle->AsString(); 79 notificationTexts.title = jsTitle->AsString();
80 } 80 }
81 JsValuePtr jsMessage = jsTexts->GetProperty("message"); 81 JsValuePtr jsMessage = jsTexts->GetProperty("message");
82 if (jsMessage->IsString()) 82 if (jsMessage->IsString())
83 { 83 {
84 notificationTexts.message = jsMessage->AsString(); 84 notificationTexts.message = jsMessage->AsString();
85 } 85 }
86 return notificationTexts; 86 return notificationTexts;
87 } 87 }
88 88
89 std::vector<std::string> Notification::GetLinks() const
90 {
91 std::vector<std::string> retValue;
92 JsValuePtr jsLinks = GetProperty("links");
93 if (!jsLinks->IsArray())
94 {
95 return retValue;
96 }
97 JsValueList urlLinksList = jsLinks->AsList();
98 for (JsValueList::const_iterator linkIterator = urlLinksList.begin();
99 linkIterator != urlLinksList.end(); ++linkIterator)
100 {
101 retValue.push_back((*linkIterator)->AsString());
102 }
103 return retValue;
104 }
105
89 void Notification::MarkAsShown() 106 void Notification::MarkAsShown()
90 { 107 {
91 JsValueList params; 108 JsValueList params;
92 params.push_back(GetProperty("id")); 109 params.push_back(GetProperty("id"));
93 jsEngine->Evaluate("API.markNotificationAsShown")->Call(params); 110 jsEngine->Evaluate("API.markNotificationAsShown")->Call(params);
94 } 111 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld