Noissue - Declare clickHideFilters and selectorList properly

include.postload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 // Click-to-hide stuff
 var clickHide_activated = false;
 var clickHide_filters = null;
 var currentElement = null;
-var clickHideFilters = null;
 var highlightedElementsSelector = null;
 var clickHideFiltersDialog = null;
 var lastRightClickEvent = null;
 
 function escapeChar(chr)
 {
   var code = chr.charCodeAt(0);
 
   // Control characters and leading digits must be escaped based on
   // their char code in CSS. Moreover, curly brackets aren't allowed
@@ skipping 355 matching lines @@
   document.removeEventListener("click", clickHide_mouseClick, true);
   document.removeEventListener("keydown", clickHide_keyDown, true);
 
   if (!keepOverlays)
   {
     if (currentElement) {
       currentElement.removeEventListener("contextmenu",  clickHide_elementClickHandler, true);
       unhighlightElements();
       unhighlightElement(currentElement);
       currentElement = null;
-      clickHideFilters = null;
     }
     unhighlightElements();
 
     var overlays = document.getElementsByClassName("__adblockplus__overlay");
     while (overlays.length > 0)
       overlays[0].parentNode.removeChild(overlays[0]);
   }
 }
 
 function clickHide_elementClickHandler(ev) {
@@ skipping 58 matching lines @@
 // popup asks for them.
 function clickHide_mouseClick(e)
 {
   if (!currentElement || !clickHide_activated)
     return;
 
   var elt = currentElement;
   if (currentElement.classList.contains("__adblockplus__overlay"))
     elt = currentElement.prisoner;
 
-  clickHideFilters = new Array();
-  selectorList = new Array();
+  var clickHideFilters = new Array();

[Sebastian Noack, 2015/01/16 20:59:15]

While changing those lines, mind using array literals?

[kzar, 2015/01/16 21:04:27]

Done.

+  var selectorList = new Array();
 
   var addSelector = function(selector)
   {
     if (selectorList.indexOf(selector) != -1)
       return;
 
     clickHideFilters.push(document.domain + "##" + selector);
     selectorList.push(selector);
   };
 
@@ skipping 202 matching lines @@
             element.parentNode.removeChild(element);
         }
         clickHide_deactivate();
         break;
     }
   });
 
   if (window == window.top)
     ext.backgroundPage.sendMessage({type: "report-html-page"});
 }