Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: adblockplus.gyp

Issue 4923675673362432: Noissue - Change build order for the include and library directories of ATL. (Closed)
Patch Set: Created May 21, 2015, 9:25 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'includes': [ 2 'includes': [
3 'defaults.gypi', 3 'defaults.gypi',
4 'common/common.gypi', 4 'common/common.gypi',
5 ], 5 ],
6 6
7 'variables': { 7 'variables': {
8 'build_type%': 'devbuild', 8 'build_type%': 'devbuild',
9 'build_version%': '', 9 'build_version%': '',
10 }, 10 },
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 'src/plugin/PluginWbPassThrough.h', 136 'src/plugin/PluginWbPassThrough.h',
137 'src/plugin/ProtocolCF.h', 137 'src/plugin/ProtocolCF.h',
138 'src/plugin/ProtocolCF.inl', 138 'src/plugin/ProtocolCF.inl',
139 'src/plugin/ProtocolImpl.h', 139 'src/plugin/ProtocolImpl.h',
140 'src/plugin/ProtocolImpl.inl', 140 'src/plugin/ProtocolImpl.inl',
141 'src/plugin/Resource.h', 141 'src/plugin/Resource.h',
142 'src/plugin/SinkPolicy.h', 142 'src/plugin/SinkPolicy.h',
143 'src/plugin/SinkPolicy.inl', 143 'src/plugin/SinkPolicy.inl',
144 ], 144 ],
145 'include_dirs': [ 145 'include_dirs': [
146 '$(WINDDKDIR)/inc/atl71',
147 '$(VCInstallDir)atlmfc/include',
146 '$(WindowsSDK_IncludePath)', 148 '$(WindowsSDK_IncludePath)',
147 '$(VCInstallDir)atlmfc/include',
148 '$(WINDDKDIR)/inc/atl71',
149 ], 149 ],
150 # See "Adding Visual Style Support to an Extension, Plug-in, MMC Snap-in or a DLL 150 # See "Adding Visual Style Support to an Extension, Plug-in, MMC Snap-in or a DLL
151 # That Is Brought into a Process" on the link here: 151 # That Is Brought into a Process" on the link here:
152 # http://msdn.microsoft.com/en-us/library/windows/desktop/bb773175%28v=vs.85 %29.aspx#using_manifests 152 # http://msdn.microsoft.com/en-us/library/windows/desktop/bb773175%28v=vs.85 %29.aspx#using_manifests
153 'defines': ['ISOLATION_AWARE_ENABLED'], 153 'defines': ['ISOLATION_AWARE_ENABLED'],
154 'libraries': [ 154 'libraries': [
155 '-lwinhttp', 155 '-lwinhttp',
156 '-lshell32', 156 '-lshell32',
157 '-lComctl32', 157 '-lComctl32',
158 '-lGdi32', 158 '-lGdi32',
(...skipping 13 matching lines...) Expand all
172 'AdditionalDependencies': ['atls.lib'], 172 'AdditionalDependencies': ['atls.lib'],
173 }, 173 },
174 }, 174 },
175 }, 175 },
176 }, 176 },
177 'msvs_settings': { 177 'msvs_settings': {
178 'VCLinkerTool': { 178 'VCLinkerTool': {
179 'conditions': [[ 179 'conditions': [[
180 'target_arch=="ia32"', { 180 'target_arch=="ia32"', {
181 'AdditionalLibraryDirectories': [ 181 'AdditionalLibraryDirectories': [
182 '$(WINDDKDIR)/lib/ATL/i386',
182 '$(VCInstallDir)atlmfc/lib', 183 '$(VCInstallDir)atlmfc/lib',
183 '$(WindowsSDK_LibraryPath_x86)', 184 '$(WindowsSDK_LibraryPath_x86)',
184 '$(WINDDKDIR)/lib/ATL/i386',
185 ], 185 ],
186 }, { 186 }, {
187 'AdditionalLibraryDirectories': [ 187 'AdditionalLibraryDirectories': [
188 '$(WINDDKDIR)/lib/ATL/amd64',
188 '$(VCInstallDir)atlmfc/lib/amd64', 189 '$(VCInstallDir)atlmfc/lib/amd64',
189 '$(WindowsSDK_LibraryPath_x64)', 190 '$(WindowsSDK_LibraryPath_x64)',
190 '$(WINDDKDIR)/lib/ATL/amd64',
191 ], 191 ],
192 } 192 }
193 ]], 193 ]],
194 'DelayLoadDLLs': ['Shell32.dll'], 194 'DelayLoadDLLs': ['Shell32.dll'],
195 }, 195 },
196 }, 196 },
197 }, 197 },
198 198
199 { 199 {
200 'target_name': 'tests', 200 'target_name': 'tests',
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 'src/plugin/PluginMimeFilterClient.cpp', 250 'src/plugin/PluginMimeFilterClient.cpp',
251 'src/plugin/PluginMutex.cpp', 251 'src/plugin/PluginMutex.cpp',
252 'src/plugin/PluginSettings.cpp', 252 'src/plugin/PluginSettings.cpp',
253 'src/plugin/PluginSystem.cpp', 253 'src/plugin/PluginSystem.cpp',
254 'src/plugin/PluginTabBase.cpp', 254 'src/plugin/PluginTabBase.cpp',
255 'src/plugin/PluginUtil.cpp', 255 'src/plugin/PluginUtil.cpp',
256 'src/plugin/PluginWbPassthrough.cpp', 256 'src/plugin/PluginWbPassthrough.cpp',
257 ], 257 ],
258 'include_dirs': [ 258 'include_dirs': [
259 '$(WINDDKDIR)/inc/atl71', 259 '$(WINDDKDIR)/inc/atl71',
260 '$(VCInstallDir)atlmfc/include',
260 ], 261 ],
261 'defines': [ 262 'defines': [
262 'WINVER=0x0501', 263 'WINVER=0x0501',
263 'PRODUCT_ADBLOCKPLUS' 264 'PRODUCT_ADBLOCKPLUS'
264 ], 265 ],
265 'link_settings': { 266 'link_settings': {
266 'libraries': ['-ladvapi32', '-lshell32', '-lole32', '-lComctl32', '-lGdi32 '], 267 'libraries': ['-ladvapi32', '-lshell32', '-lole32', '-lComctl32', '-lGdi32 '],
267 }, 268 },
268 'msvs_settings': { 269 'msvs_settings': {
269 'VCLinkerTool': { 270 'VCLinkerTool': {
270 'SubSystem': '1', # Console 271 'SubSystem': '1', # Console
271 'EntryPointSymbol': 'mainCRTStartup', 272 'EntryPointSymbol': 'mainCRTStartup',
272 'conditions': [[ 273 'conditions': [[
273 'target_arch=="ia32"', { 274 'target_arch=="ia32"', {
274 'AdditionalLibraryDirectories': [ 275 'AdditionalLibraryDirectories': [
276 '$(WINDDKDIR)/lib/ATL/i386',
275 '$(VCInstallDir)atlmfc/lib', 277 '$(VCInstallDir)atlmfc/lib',
276 '$(WindowsSDK_LibraryPath_x86)', 278 '$(WindowsSDK_LibraryPath_x86)',
277 '$(WINDDKDIR)/lib/ATL/i386',
278 ], 279 ],
279 }, { 280 }, {
280 'AdditionalLibraryDirectories': [ 281 'AdditionalLibraryDirectories': [
282 '$(WINDDKDIR)/lib/ATL/amd64',
281 '$(VCInstallDir)atlmfc/lib/amd64', 283 '$(VCInstallDir)atlmfc/lib/amd64',
282 '$(WindowsSDK_LibraryPath_x64)', 284 '$(WindowsSDK_LibraryPath_x64)',
283 '$(WINDDKDIR)/lib/ATL/amd64',
284 ], 285 ],
285 } 286 }
286 ]], 287 ]],
287 }, 288 },
288 }, 289 },
289 'configurations': { 290 'configurations': {
290 # 'libraries' is not allowed under 'configurations' :-( 291 # 'libraries' is not allowed under 'configurations' :-(
291 'Debug': { 292 'Debug': {
292 'msvs_settings': { 293 'msvs_settings': {
293 'VCLinkerTool': { 294 'VCLinkerTool': {
294 'AdditionalDependencies': ['atlsd.lib'], 295 'AdditionalDependencies': ['atlsd.lib'],
295 }, 296 },
296 }, 297 },
297 }, 298 },
298 'Release': { 299 'Release': {
299 'msvs_settings': { 300 'msvs_settings': {
300 'VCLinkerTool': { 301 'VCLinkerTool': {
301 'AdditionalDependencies': ['atls.lib'], 302 'AdditionalDependencies': ['atls.lib'],
302 }, 303 },
303 }, 304 },
304 }, 305 },
305 }, 306 },
306 }] 307 }]
307 } 308 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld