Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/org/adblockplus/android/Preferences.java

Issue 5046897395892224: Issue 1532 - Subscription summary added even if empty (Closed)
Patch Set: Created Nov. 6, 2014, 10:50 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/org/adblockplus/android/Preferences.java
diff --git a/src/org/adblockplus/android/Preferences.java b/src/org/adblockplus/android/Preferences.java
index 29440c03635291965b34993c37e66e43a219b1be..3f63d48b9366fe0dbf9639b72f635066dd323e4f 100755
--- a/src/org/adblockplus/android/Preferences.java
+++ b/src/org/adblockplus/android/Preferences.java
@@ -23,6 +23,7 @@ import java.io.OutputStream;
import java.util.Calendar;
import java.util.Date;
+import org.apache.commons.lang.StringUtils;
import org.jraf.android.backport.switchwidget.SwitchPreference;
import android.app.AlertDialog;
@@ -538,7 +539,7 @@ public class Preferences extends SummarizedPreferences
if (summary != null)
{
builder.append(summary);
- if (text != "")
+ if (StringUtils.isNotEmpty(text))
{
builder.append(" (");
final int id = getResources().getIdentifier(text, "string", getPackageName());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld