Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: cms/utils.py

Issue 5148261828526080: Issue 2119 - Add get_page_content template function. (Closed)
Patch Set: Use for, break, else control flow for page format guessing. Created April 8, 2015, 8:46 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cms/converters.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # coding: utf-8 1 # coding: utf-8
2 2
3 # This file is part of the Adblock Plus web scripts, 3 # This file is part of the Adblock Plus web scripts,
4 # Copyright (C) 2006-2015 Eyeo GmbH 4 # Copyright (C) 2006-2015 Eyeo GmbH
5 # 5 #
6 # Adblock Plus is free software: you can redistribute it and/or modify 6 # Adblock Plus is free software: you can redistribute it and/or modify
7 # it under the terms of the GNU General Public License version 3 as 7 # it under the terms of the GNU General Public License version 3 as
8 # published by the Free Software Foundation. 8 # published by the Free Software Foundation.
9 # 9 #
10 # Adblock Plus is distributed in the hope that it will be useful, 10 # Adblock Plus is distributed in the hope that it will be useful,
11 # but WITHOUT ANY WARRANTY; without even the implied warranty of 11 # but WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details. 13 # GNU General Public License for more details.
14 # 14 #
15 # You should have received a copy of the GNU General Public License 15 # You should have received a copy of the GNU General Public License
16 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 16 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
17 17
18 from .converters import converters, TemplateConverter 18 from .converters import converters, TemplateConverter
19 19
20 def process_page(source, locale, page, format, site_url_override=None): 20 def get_page_params(source, locale, page, format=None, site_url_override=None):
21 # Guess page format if omitted, but default to Markdown for friendlier excepti ons
22 if format is None:
23 for format in converters.keys():
Sebastian Noack 2015/04/08 09:09:32 Nit: This creates a new list with all the keys in
kzar 2015/04/08 09:32:11 Done.
24 if source.has_page(page, format):
25 break
26 else:
27 format = "md"
28
21 params = { 29 params = {
22 "source": source, 30 "source": source,
23 "template": "default", 31 "template": "default",
24 "locale": locale, 32 "locale": locale,
25 "page": page, 33 "page": page,
26 "pagedata": source.read_page(page, format), 34 "pagedata": source.read_page(page, format),
27 "config": source.read_config(), 35 "config": source.read_config(),
28 } 36 }
29 37
30 localefile = page 38 localefile = page
31 if params["config"].has_option("locale_overrides", page): 39 if params["config"].has_option("locale_overrides", page):
32 localefile = params["config"].get("locale_overrides", page) 40 localefile = params["config"].get("locale_overrides", page)
33 params["localedata"] = source.read_locale(params["locale"], localefile) 41 params["localedata"] = source.read_locale(params["locale"], localefile)
34 42
35 if params["config"].has_option("general", "siteurl"): 43 if params["config"].has_option("general", "siteurl"):
36 if site_url_override: 44 if site_url_override:
37 params["site_url"] = site_url_override 45 params["site_url"] = site_url_override
38 else: 46 else:
39 params["site_url"] = params["config"].get("general", "siteurl") 47 params["site_url"] = params["config"].get("general", "siteurl")
40 48
41 try: 49 try:
42 converter = converters[format](params) 50 converter = converters[format](params)
43 except KeyError: 51 except KeyError:
44 raise Exception("Page %s uses unknown format %s" % (page, format)) 52 raise Exception("Page %s uses unknown format %s" % (page, format))
45 53
46 # Note: The converter might change some parameters so we can only read in 54 # Note: The converter might change some parameters so we can only read in
47 # template data here. 55 # template data here.
48 params["templatedata"] = source.read_template(params["template"]) 56 params["templatedata"] = source.read_template(params["template"])
49 template_converter = TemplateConverter(params, key="templatedata")
50 57
51 defaultlocale = params["config"].get("general", "defaultlocale") 58 defaultlocale = params["config"].get("general", "defaultlocale")
52 params["defaultlocale"] = defaultlocale 59 params["defaultlocale"] = defaultlocale
53 60
54 locales = [ 61 locales = [
55 locale 62 locale
56 for locale in source.list_locales() 63 for locale in source.list_locales()
57 if source.has_locale(locale, localefile) 64 if source.has_locale(locale, localefile)
58 ] 65 ]
59 if defaultlocale not in locales: 66 if defaultlocale not in locales:
60 locales.append(defaultlocale) 67 locales.append(defaultlocale)
61 locales.sort() 68 locales.sort()
62 params["available_locales"] = locales 69 params["available_locales"] = locales
63 70
64 params["head"], params["body"] = converter() 71 params["head"], params["body"] = converter()
65 return template_converter() 72 return params
73
74 def process_page(source, locale, page, format, site_url_override=None):
75 return TemplateConverter(
76 get_page_params(source, locale, page, format, site_url_override),
77 key="templatedata"
78 )()
OLDNEW
« no previous file with comments | « cms/converters.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld