Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: manifest.json.tmpl

Issue 5163192602853376: Issue 364 - Extension manifest changes necessary to upload devbuilds (Closed)
Patch Set: Created April 25, 2014, 8:14 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: manifest.json.tmpl
===================================================================
--- a/manifest.json.tmpl
+++ b/manifest.json.tmpl
@@ -12,26 +12,31 @@
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
*/
{
"manifest_version": 2,
- "name": "__MSG_name__{% if experimentalAPI %} experimental build{% endif %}",
Sebastian Noack 2014/04/25 09:19:01 LGTM, assuming that the "experimental build" is de
Wladimir Palant 2014/04/25 09:46:52 It is, we no longer link to the experimental build
+ {%- if releaseBuild %}
+ "name": "__MSG_name__",
+ {%- else %}
+ "name": "__MSG_name_devbuild__",
+ {%- endif %}
+
"description": "__MSG_description_{{ type }}__",
"default_locale": "en_US",
"version": {{version|json}},
{%- if metadata.has_section('compat') and metadata.has_option('compat', 'chrome') %}
"minimum_chrome_version": {{metadata.get('compat', 'chrome')|json}},
{%- endif %}
- {%- if not releaseBuild %}
+ {%- if not releaseBuild and type != "chrome" %}
"update_url": "https://adblockplus.org/devbuilds/
{{- metadata.get('general', 'basename') -}}
{%- if experimentalAPI -%}
-experimental
{%- endif -%}
/updates.xml",
{%- elif metadata.has_option('general', 'updateURL') %}
"update_url": {{metadata.get('general', 'updateURL')|json}},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld