Issue 768 - Switch from TR1 to C++11

include/AdblockPlus/JsValue.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifndef ADBLOCK_PLUS_JS_VALUE_H
 #define ADBLOCK_PLUS_JS_VALUE_H
 
 #include <stdint.h>
 #include <string>
 #include <vector>
+#include <memory>
 #include "V8ValueHolder.h"

[Wladimir Palant, 2015/08/05 11:19:39]

You are assuming that <vector> will include <memory> internally. IMHO that's a
bad idea, you should just spell out your requirements explicitly without making
any assumptions.

[sergei, 2015/08/06 07:35:30]

<vector> does not include <memory>, it's included by "V8ValueHolder.h". Anyway I
find it a good idea to include <memory> here now.

[Wladimir Palant, 2015/08/06 12:24:54]

So, will you do it? :)

[sergei, 2015/08/07 06:29:39]

Sorry, overlooked.

 
 namespace v8
 {
   class Value;
   template<class T> class Handle;
   template<class T> class Local;
 }
 
 namespace AdblockPlus
 {
@@ skipping 92 matching lines @@
     JsValue(JsValuePtr value);
     JsEnginePtr jsEngine;
   private:
     JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);
     void SetProperty(const std::string& name, v8::Handle<v8::Value> val);
     V8ValueHolder<v8::Value> value;
   };
 }
 
 #endif