Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/background.js

Issue 5203617959116800: Fixed regression: Context menu clickhide broken (Closed)
Left Patch Set: Created Nov. 28, 2013, 3:08 p.m.
Right Patch Set: Created Dec. 9, 2013, 4:29 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « background.js ('k') | safari/background.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 onActivated: new ActivatedTabEventTarget(), 345 onActivated: new ActivatedTabEventTarget(),
346 onRemoved: new RemovedTabEventTarget() 346 onRemoved: new RemovedTabEventTarget()
347 }; 347 };
348 348
349 ext.webRequest = { 349 ext.webRequest = {
350 onBeforeRequest: new BeforeRequestEventTarget(), 350 onBeforeRequest: new BeforeRequestEventTarget(),
351 handlerBehaviorChanged: chrome.webRequest.handlerBehaviorChanged 351 handlerBehaviorChanged: chrome.webRequest.handlerBehaviorChanged
352 }; 352 };
353 353
354 ext.contextMenus = { 354 ext.contextMenus = {
355 create: function(title, contexts, onclick) { 355 create: function(title, contexts, onclick)
Felix Dahlke 2013/12/04 15:24:02 { should go on a new line, likewise below.
Thomas Greiner 2013/12/09 16:33:48 Done.
356 {
356 chrome.contextMenus.create({ 357 chrome.contextMenus.create({
357 title: title, 358 title: title,
358 contexts: contexts, 359 contexts: contexts,
359 onclick: function(info, tab) 360 onclick: function(info, tab)
360 { 361 {
361 onclick(info, new Tab(tab)); 362 onclick(info.srcUrl, new Tab(tab));
Sebastian Noack 2013/11/28 23:17:41 The OnClickData is a rich data structue with some
Thomas Greiner 2013/12/09 16:33:48 Done.
362 } 363 }
363 }); 364 });
364 }, 365 },
365 removeAll: function(callback) { 366 removeAll: function(callback)
367 {
366 chrome.contextMenus.removeAll(callback); 368 chrome.contextMenus.removeAll(callback);
367 } 369 }
368 }; 370 };
369 })(); 371 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld