Issue 2212 - Implement http://subscribe.adblockplus.org/?... subscription links

include.postload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 592 matching lines @@
   }, true);
 
   document.addEventListener("click", function(event)
   {
     // Ignore right-clicks
     if (event.button == 2)
       return;
 
     // Search the link associated with the click
     var link = event.target;
-    while (link && !(link instanceof HTMLAnchorElement))
+    while (!(link instanceof HTMLAnchorElement))
+    {
       link = link.parentNode;
 
-    if (!link || link.protocol != "abp:")
+      if (!link)
+        return;
+    }
+
+    if (link.protocol == "http:" || link.protocol == "https:")

[kzar, 2015/03/25 14:09:29]

(Do we even need to support http? I guess we will always use https for
subscribe.adblockplus.org links?)

[Sebastian Noack, 2015/03/25 14:21:04]

We probably will. But others linking to our website might not. And since we
aren't going to intercept requests but just link clicking here, we won't see the
redirect.

+    {
+      if (link.host != "subscribe.adblockplus.org" || link.pathname != "/")
+        return;
+    }
+    else if (!/^abp:\/*subscribe\/*\?(.*)/i.test(link.href))

[Thomas Greiner, 2015/03/25 15:05:36]

The `(.*)` at the end of the regular expression is redundant now.

[Wladimir Palant, 2015/03/25 15:07:17]

Nit: Please remove the parentheses in this regexp if you aren't going to use the
group.

[Sebastian Noack, 2015/03/25 15:23:26]

Done.

       return;
 
     // This is our link - make sure the browser doesn't handle it
     event.preventDefault();
     event.stopPropagation();
 
-    var linkTarget = link.href;
-    if (!/^abp:\/*subscribe\/*\?(.*)/i.test(linkTarget))  /**/
-      return;
-
     // Decode URL parameters
-    var params = RegExp.$1.split("&");
+    var params = link.search.substr(1).split("&");

[Wladimir Palant, 2015/03/25 15:07:17]

Note that this change will make the approach inconsistent between Firefox and
Chrome - Firefox (unlike Chrome and Safari) won't extract the query string for
unknown protocols.

[Sebastian Noack, 2015/03/25 15:23:26]

Well, the alternative would be to make things inconsistent between abp: and
http: URLs, introducing redundant logic here.

     var title = null;
     var url = null;
     for (var i = 0; i < params.length; i++)
     {
       var parts = params[i].split("=", 2);
       if (parts.length != 2 || !/\S/.test(parts[1]))
         continue;
       switch (parts[0])
       {
         case "title":
@@ skipping 91 matching lines @@
           lastRightClickEventValid = false;
         else
           lastRightClickEvent = null;
         break;
     }
   });
 
   if (window == window.top)
     ext.backgroundPage.sendMessage({type: "report-html-page"});
 }