Merge filter and notification servers, have both tasks run on the same servers

modules/filterserver/manifests/init.pp

-class filterserver {
-  class {'nginx':
-    worker_processes => 2,
-    worker_connections => 4000,
-    ssl_session_cache => off,
+class filterserver($is_default = false) {
+  if $is_default {
+    class {'nginx':

[Felix Dahlke, 2014/01/30 13:51:48]

Based on the Puppet documentation, I think this should work:

if !defined(Class['nginx']) {
  class {'nginx':
  …
}

Likewise for /var/www below. I'd prefer that to $is_default if it works.

+      worker_processes => 2,
+      worker_connections => 4000,
+      ssl_session_cache => off,
+    }
+
+    file {'/var/www':
+      ensure => directory,
+      owner => nginx,
+      mode => 0755,
+      require => Package['nginx']
+    }
   }
 
   user {'subscriptionstat':
     ensure => absent,
   }
 
   user {'rsync':
     ensure => present,
     comment => 'Filter list mirror user',
     home => '/home/rsync',
     managehome => true
   }
 
   File {
     owner => root,
     group => root,
     mode => 0644,
   }
 
-  file {'/var/www':
-    ensure => directory
-  }
-
   file {'/var/www/easylist':
     ensure => directory,
-    require => [
-                 File['/var/www'],
-                 User['rsync']
-               ],
     owner => rsync
   }
 
   file {'/etc/nginx/sites-available/inc.easylist-downloads':
     ensure => absent,
   }
 
   file {'/etc/nginx/sites-available/inc.easylist-downloads-txt':
     ensure => absent
   }
@@ skipping 11 matching lines @@
 
   file {'/etc/nginx/sites-available/easylist-downloads.adblockplus.org_sslcert.pem':
     ensure => file,
     notify => Service['nginx'],
     before => Nginx::Hostconfig['easylist-downloads.adblockplus.org'],
     mode => 0400,
     source => 'puppet:///modules/private/easylist-downloads.adblockplus.org_sslcert.pem'
   }
 
   nginx::hostconfig{'easylist-downloads.adblockplus.org':
-    source => 'puppet:///modules/filterserver/easylist-downloads.adblockplus.org',
+    content => template('filterserver/easylist-downloads.adblockplus.org.erb'),
     enabled => true
   }
 
   file {'/etc/logrotate.d/nginx_easylist-downloads.adblockplus.org':
     ensure => file,
     require => Nginx::Hostconfig['easylist-downloads.adblockplus.org'],
     source => 'puppet:///modules/filterserver/logrotate'
   }
 
   file {'/home/rsync/.ssh':
     ensure => directory,
     require => User['rsync'],
     owner => rsync,
     mode => 0600;
   }
 
   concat {'/home/rsync/.ssh/known_hosts':
     owner => rsync,
     mode => 0444,
   }
 
-
   concat::fragment {'filtermaster_hostname':
-     target => '/home/rsync/.ssh/known_hosts',
-     content => 'filtermaster.adblockplus.org ',
-     order => 1,
+    target => '/home/rsync/.ssh/known_hosts',
+    content => 'filtermaster.adblockplus.org ',
+    order => 1,
   }
 
-   concat::fragment {'filtermaster_hostkey':
-     target => '/home/rsync/.ssh/known_hosts',
-     source => 'puppet:///modules/private/filtermaster.adblockplus.org_ssh.pub',
-     order => 2,
+  concat::fragment {'filtermaster_hostkey':
+    target => '/home/rsync/.ssh/known_hosts',
+    source => 'puppet:///modules/private/filtermaster.adblockplus.org_ssh.pub',
+    order => 2,
   }
 
   file {'/home/rsync/.ssh/id_rsa':
     ensure => file,
     require => [
                  File['/home/rsync/.ssh'],
                  User['rsync']
                ],
     owner => rsync,
     mode => 0400,
@@ skipping 18 matching lines @@
                  File['/home/rsync/.ssh/id_rsa'],
                  User['rsync']
                ],
     command => 'rsync -e "ssh -o CheckHostIP=no" -ltprz --delete rsync@filtermaster.adblockplus.org:. /var/www/easylist/',
     environment => ['MAILTO=admins@adblockplus.org,root'],
     user => rsync,
     hour => '*',
     minute => '2-52/10'
   }
 }