Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: html/static/js/IESettings.js

Issue 5427527162003456: Issue 1086 - Add acceptable ads checkbox to the settings page (Closed)
Left Patch Set: Moved from onchange in html to addListener in JS Created July 22, 2014, 2:22 p.m.
Right Patch Set: Cosmetic fixes Created July 22, 2014, 3:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | html/templates/index.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 function init() 1 function init()
2 { 2 {
3 try 3 try
4 { 4 {
5 initLanguageSettings(); 5 initLanguageSettings();
6 6
7 initDomainSettings(); 7 initDomainSettings();
8 } 8 }
9 catch (err) 9 catch (err)
10 { 10 {
11 // alert("err: " + err); 11 //alert("err: " + err);
Felix Dahlke 2014/07/22 14:28:10 That change seems unrelated :D
12 } 12 }
13 } 13 }
14 14
15 function setElementText(id, key) 15 function setElementText(id, key)
16 { 16 {
17 var el = document.getElementById(id); 17 var el = document.getElementById(id);
18 if (el) 18 if (el)
19 { 19 {
20 var text = UserSettings().GetMessage("settings", key); 20 var text = UserSettings().GetMessage("settings", key);
21 if (text) 21 if (text)
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 for (var i = removeOptions.length; i--;) 155 for (var i = removeOptions.length; i--;)
156 { 156 {
157 optionsDomain.remove(removeOptions[i]); 157 optionsDomain.remove(removeOptions[i]);
158 } 158 }
159 }, false); 159 }, false);
160 } 160 }
161 161
162 window.UserSettings = function() 162 window.UserSettings = function()
163 { 163 {
164 return window.Settings; 164 return window.Settings;
165 } 165 }
Felix Dahlke 2014/07/22 14:28:10 Was this a missing EOF? If so let's keep it.
LEFTRIGHT

Powered by Google App Engine
This is Rietveld