Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: manifests/codereviewserver.pp
Issue
5459448122310656
:
Add rietveld to infrastructure (Closed)
Patch Set: The two comments
Created Feb. 12, 2014, 2:13 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Apply Changes
Patch Set 3: Add Changes
Patch Set 4: The two comments
Patch Set 5: Remove small dependency
Right:
Patch Set 1: None
Patch Set 2: Apply Changes
Patch Set 3: Add Changes
Patch Set 4: The two comments
Patch Set 5: Remove small dependency
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Vagrantfile
manifests/codereviewserver.pp
manifests/monitoringserver.pp
manifests/nodes.pp
manifests/vagrant.pp
modules/private-stub/manifests/rietveld.pp
modules/rietveld/files/Makefile
modules/rietveld/files/rietveld.conf
modules/rietveld/manifests/init.pp
modules/rietveld/templates/settings.py.erb
modules/rietveld/templates/site.erb
View unified diff
|
Download patch
« no previous file with comments
|
« Vagrantfile
('k') |
manifests/monitoringserver.pp »
('j') |
modules/rietveld/manifests/init.pp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
node 'codereview1' {
2
include base
3
class {'rietveld':
4
domain => 'codereview.adblockplus.org'
5
}
6
7
class {'nagios::client':
8
server_address => 'monitoring.adblockplus.org'
9
}
10
}
OLD
NEW
« no previous file with comments
|
« Vagrantfile
('k') |
manifests/monitoringserver.pp »
('j') |
modules/rietveld/manifests/init.pp »
('J')
Edit Message
Issue 5459448122310656: Add rietveld to infrastructure (Closed)
Created Feb. 7, 2014, 8:46 a.m. by christian
Modified Feb. 12, 2014, 5:34 p.m.
Reviewers: Felix Dahlke
Base URL:
Comments: 47
This is Rietveld