lib/keySelector.js - Issue 5462707926990848: Issue 1434 - Removed remaining non-standard JavaScript code from buildtools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: lib/keySelector.js

Issue 5462707926990848: Issue 1434 - Removed remaining non-standard JavaScript code from buildtools (Closed)

Left Patch Set: Replaced some more function expressions Created April 1, 2015, 2:26 p.m.

Right Patch Set: Rebased Created Dec. 16, 2015, noon

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /* This Source Code Form is subject to the terms of the Mozilla Public	1 /* This Source Code Form is subject to the terms of the Mozilla Public

2 * License, v. 2.0. If a copy of the MPL was not distributed with this	2 * License, v. 2.0. If a copy of the MPL was not distributed with this

3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */	3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

4	4

5 Cu.import("resource://gre/modules/Services.jsm");	5 Cu.import("resource://gre/modules/Services.jsm");

6	6

7 let validModifiers = Object.create(null);	7 let validModifiers = Object.create(null);

8 validModifiers.ACCEL = null;	8 validModifiers.ACCEL = null;

9 validModifiers.CTRL = "control";	9 validModifiers.CTRL = "control";

10 validModifiers.CONTROL = "control";	10 validModifiers.CONTROL = "control";

(...skipping 192 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
203 return false;	203 return false;

204 if (key.meta != event.metaKey \|\| key.control != event.ctrlKey)	204 if (key.meta != event.metaKey \|\| key.control != event.ctrlKey)

205 return false;	205 return false;

206	206

207 if (key.char && event.charCode && String.fromCharCode(event.charCode).toUpperC ase() == key.char)	207 if (key.char && event.charCode && String.fromCharCode(event.charCode).toUpperC ase() == key.char)

208 return true;	208 return true;

209 if (key.code && event.keyCode && event.keyCode == key.code)	209 if (key.code && event.keyCode && event.keyCode == key.code)

210 return true;	210 return true;

211 return false;	211 return false;

212 };	212 };

LEFT	RIGHT