README.md - Issue 5519479341580288: Issue 2437 - Update adblockplus dependency to revision 752ffe2eeaf1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 5519479341580288: Issue 2437 - Update adblockplus dependency to revision 752ffe2eeaf1 (Closed)

Left Patch Set: Created April 29, 2015, 4:44 p.m.

Right Patch Set: Run ensure_dependencies.py during the build Created May 29, 2015, 7:12 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 libadblockplus	1 libadblockplus

2 ==============	2 ==============

3	3

4 A C++ library offering the core functionality of Adblock Plus.	4 A C++ library offering the core functionality of Adblock Plus.

5	5

6 Getting/updating the dependencies	6 Getting/updating the dependencies

7 ---------------------------------	7 ---------------------------------

8	8

9 libadblockplus has dependencies that aren't part of this repository. To update	9 libadblockplus has dependencies that aren't part of this repository. They are

10 those, run the following after every repository update:	10 retrieved and updated during the build process, but you can also manually update

	11 them by running the following:

11	12

12 ./ensure_dependencies.py	13 ./ensure_dependencies.py
Wladimir Palant 2015/04/29 17:42:57 I still think that this should be part of the buil I still think that this should be part of the build process. Not sure what your problem with that is but ensure_dependencies.py will merely produce a warning if you have local changes. Felix Dahlke 2015/04/30 05:06:11 Let's move that discussion here: https://intraforu Show quoted text On 2015/04/29 17:42:57, Wladimir Palant wrote: > I still think that this should be part of the build process. Not sure what your > problem with that is but ensure_dependencies.py will merely produce a warning if > you have local changes. Let's move that discussion here: https://intraforum.adblockplus.org/t/calling-ensure-dependencies-py-at-build-...
13	14

14 Building	15 Building

15 --------	16 --------

16	17

17 ### Unix	18 ### Unix

18	19

19 All you need is Python 2.6 and Make:	20 All you need is Python 2.6 and Make:

20	21

21 make	22 make

22	23

(...skipping 173 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
196	197

197 ### Unix	198 ### Unix

198	199

199 The shell is automatically built by `make`, you can run it as follows:	200 The shell is automatically built by `make`, you can run it as follows:

200	201

201 build/out/abpshell	202 build/out/abpshell

202	203

203 ### Windows	204 ### Windows

204	205

205 Just run the project abpshell.	206 Just run the project abpshell.

LEFT	RIGHT