Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsValue.cpp

Issue 5598762307158016: Issue 1550 - Get rid of V8ValueHolder.h (Closed)
Patch Set: update Created June 11, 2015, 1:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/JsEngine.cpp ('k') | src/Notification.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/JsValue.cpp
diff --git a/src/JsValue.cpp b/src/JsValue.cpp
index 77a005ba51f0bcd5647f2942730c1b8cc74372b0..04b9c84ec375eb794a5f90f2fed830a3c7ee5b48 100644
--- a/src/JsValue.cpp
+++ b/src/JsValue.cpp
@@ -25,13 +25,13 @@
AdblockPlus::JsValue::JsValue(AdblockPlus::JsEnginePtr jsEngine,
v8::Handle<v8::Value> value)
: jsEngine(jsEngine),
- value(jsEngine->isolate, value)
+ value(new v8::Persistent<v8::Value>(jsEngine->isolate, value))
{
}
-AdblockPlus::JsValue::JsValue(AdblockPlus::JsValuePtr value)
- : jsEngine(value->jsEngine),
- value(value->value)
+AdblockPlus::JsValue::JsValue(AdblockPlus::JsValue&& src)
+ : jsEngine(src.jsEngine),
+ value(std::move(src.value))
{
}
@@ -163,7 +163,7 @@ void AdblockPlus::JsValue::SetProperty(const std::string& name, v8::Handle<v8::V
v8::Local<v8::Value> AdblockPlus::JsValue::UnwrapValue() const
{
- return v8::Local<v8::Value>::New(jsEngine->isolate, value);
+ return v8::Local<v8::Value>::New(jsEngine->isolate, *value);
}
void AdblockPlus::JsValue::SetProperty(const std::string& name, const std::string& val)
@@ -208,7 +208,8 @@ AdblockPlus::JsValuePtr AdblockPlus::JsValue::Call(const JsValueList& params, Js
const JsContext context(jsEngine);
if (!thisPtr)
{
- v8::Local<v8::Context> localContext = v8::Local<v8::Context>::New(jsEngine->isolate, jsEngine->context);
+ v8::Local<v8::Context> localContext = v8::Local<v8::Context>::New(
+ jsEngine->isolate, *jsEngine->context);
thisPtr = JsValuePtr(new JsValue(jsEngine, localContext->Global()));
}
if (!thisPtr->IsObject())
« no previous file with comments | « src/JsEngine.cpp ('k') | src/Notification.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld