Addressed comment on review 6308777468887040

include.postload.js

Index: include.postload.js
===================================================================
--- a/include.postload.js
+++ b/include.postload.js
@@ -316,10 +316,6 @@
   // Show popup
   clickHide_showDialog(e.clientX, e.clientY, clickHideFilters);
 
-  // Set background color in case it got selected using context menu
-  if (typeof currentElement_backgroundColor == "undefined")
-    currentElement_backgroundColor = currentElement.style.backgroundColor;
-
   // Highlight the unlucky elements
   // Restore currentElement's box-shadow and bgcolor so that highlightElements won't save those
   currentElement.style.setProperty("-webkit-box-shadow", currentElement_boxShadow);
@@ -554,6 +550,7 @@
           // Coerce red highlighted overlay on top of element to remove.
           // TODO: Wow, the design of the clickHide stuff is really dumb - gotta fix it sometime
           currentElement = addElementOverlay(target);
+          currentElement_backgroundColor = currentElement.style.backgroundColor;

[Wladimir Palant, 2013/12/18 12:19:25]

From the look of it, this won't work correctly. You are remembering the
background color of the temporary overlay element. clickHide_showDialog() will
remove that overlay and restore the wrong background color later. IMHO this
should be target.style.backgroundColor.

[Thomas Greiner, 2013/12/18 12:24:02]

Done, you are right. We should change the variable name at some point given that
the overlay is called currentElement but currentElement_backgroundColor is not
the background color of the overlay.

           // clickHide_mouseOver(lastRightClickEvent);
           clickHide_mouseClick(lastRightClickEvent);
         }