Issue 309 - Don't use Shadow DOM in Chrome 32

include.preload.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 10 matching lines @@
 function setElemhideCSSRules(selectors)
 {
   if (selectors.length == 0)
     return;
 
   var style = document.createElement("style");
   style.setAttribute("type", "text/css");
 
   // Use Shadow DOM if available to don't mess with web pages that
   // rely on the order of their own <style> tags. However
-  // the <shadow> element is broken in Chrome 32.0.1700 (#309)
-  var match;
-  if ("webkitCreateShadowRoot" in document.documentElement && !((match = navigator.userAgent.match(/\bChrome\/32\.0\.(\d+)\b/)) && parseInt(match[1]) >= 1700))

[Thomas Greiner, 2014/04/17 17:39:00]

Nit: That's an unnecessarily long line. You could for instance move the variable
initialization outside of the if-statement and break on each &&.

var match = navigator.userAgent.match(/\bChrome\/32\.0\.(\d+)\b/);
if ("webkitCreateShadowRoot" in document.documentElement
  && !((match && parseInt(match[1]) >= 1700))

[Sebastian Noack, 2014/04/17 17:56:45]

The reason I did it that way is, is to don't execute the regex if Shadow DOM
isn't supported. However that variable is gone anyway, in the new patch set.

+  // the <shadow> element is broken in some Chrome 32 builts (#309)

[Thomas Greiner, 2014/04/22 09:47:04]

Nit: Correct "builts" to "builds"

+  if ("webkitCreateShadowRoot" in document.documentElement && !/\bChrome\/32\b/.test(navigator.userAgent))
   {
     var shadow = document.documentElement.webkitCreateShadowRoot();
     shadow.appendChild(document.createElement("shadow"));
     shadow.appendChild(style);
 
     try
     {
       document.querySelector("::content");
 
       for (var i = 0; i < selectors.length; i++)
@@ skipping 79 matching lines @@
     ext.backgroundPage.sendMessage({type: "add-key-exception", token: attr});
 
   ext.backgroundPage.sendMessage({type: "get-selectors"}, setElemhideCSSRules);
 }
 
 // In Chrome 18 the document might not be initialized yet
 if (document.documentElement)
   init();
 else
   window.setTimeout(init, 0);