include.preload.js - Issue 5715983079571456: Issue 309 - Don't use Shadow DOM in Chrome 32

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include.preload.js

Issue 5715983079571456: Issue 309 - Don't use Shadow DOM in Chrome 32 (Closed)

Patch Set: Created April 17, 2014, 2:25 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: include.preload.js

===================================================================

--- a/include.preload.js

+++ b/include.preload.js

@@ -29,7 +29,7 @@

// Use Shadow DOM if available to don't mess with web pages that

// rely on the order of their own <style> tags. However

// the <shadow> element is broken in Chrome 32.0.1700 (#309)

- if ("webkitCreateShadowRoot" in document.documentElement && !/\bChrome\/32\.0\.1700\b/.test(navigator.userAgent))

+ if ("webkitCreateShadowRoot" in document.documentElement && !(/\bChrome\/32\.0\.(\d+)\b/.test(navigator.userAgent) && RegExp.$1 >= 1700))

Thomas Greiner 2014/04/17 15:55:57 RegExp.$1 is deprecated (see https://developer.moz

Thomas Greiner 2014/04/17 15:55:57 The match that you get from the regular expression

Sebastian Noack 2014/04/17 16:16:35 Done.

{

var shadow = document.documentElement.webkitCreateShadowRoot();

shadow.appendChild(document.createElement("shadow"));

« no previous file with comments | « no previous file | no next file » | no next file with comments »