Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: webrequest.js

Issue 5733084272001024: Issue 2368 - Update adblockplus dependency to revision feb391127fe4 (Closed)
Patch Set: Hint that there may not be a notification for the supplied URL Created June 12, 2015, 6:23 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/notificationHelper.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrequest.js
===================================================================
--- a/webrequest.js
+++ b/webrequest.js
@@ -18,7 +18,7 @@
var FilterNotifier = require("filterNotifier").FilterNotifier;
var RegExpFilter = require("filterClasses").RegExpFilter;
var platform = require("info").platform;
-var showNextNotification = require("notificationHelper").showNextNotification;
+var showNextNotificationForUrl = require("notificationHelper").showNextNotificationForUrl;
ext.webRequest.indistinguishableTypes.forEach(function(types)
{
@@ -52,7 +52,7 @@
// We can't listen to onHeadersReceived in Safari so we need to
// check for notifications here
if (platform != "chromium" && type == "SUBDOCUMENT")
- showNextNotification(url);
+ showNextNotificationForUrl(url);
if (filter)
FilterNotifier.triggerListeners("filter.hitCount", filter, 0, 0, page);
@@ -96,7 +96,7 @@
processKey(header.value, page, frame);
}
- showNextNotification(new URL(details.url));
+ showNextNotificationForUrl(new URL(details.url));
}
chrome.webRequest.onHeadersReceived.addListener(
« no previous file with comments | « lib/notificationHelper.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld