Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/firstRun.js

Issue 5743229060251648: Show warning about unsupported Safari version on first run page also for Safari 6.1 and 7.0 (Closed)
Patch Set: Created Nov. 28, 2013, 11:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/locale/en-US/firstRun.properties » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/firstRun.js
===================================================================
--- a/chrome/content/ui/firstRun.js
+++ b/chrome/content/ui/firstRun.js
@@ -63,9 +63,13 @@
setLinks("dataCorruptionWarning", Utils.getDocLink("knownIssuesChrome_filterstorage"));
}
- // Show warning if Safari < 6
+ // Show warning if Safari version isn't supported
var info = require("info");
- if (info.platform == "safari" && Services.vc.compare(info.platformVersion, "6.0") < 0)
+ if (info.platform == "safari" && (
+ Services.vc.compare(info.platformVersion, "6.0") < 0 || // beforeload breaks websites in Safari 5
+ Services.vc.compare(info.platformVersion, "6.1") == 0 || // extensions are broken in 6.1 and 7.0
+ Services.vc.compare(info.platformVersion, "7.0") == 0
+ ))
E("legacySafariWarning").removeAttribute("hidden");
// Set up feature buttons linked to subscriptions
« no previous file with comments | « no previous file | chrome/locale/en-US/firstRun.properties » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld