Unified Diff: lib/ui.js
Issue 5749479856668672:
issue #764 - Adblock Warning opt in message isn't triggered (Closed)
Patch Set:
Created July 9, 2014, 6:39 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/ui.js |
| =================================================================== |
| --- a/lib/ui.js |
| +++ b/lib/ui.js |
| @@ -1887,8 +1887,10 @@ |
| let messageElement = window.document.getElementById("abp-notification-message"); |
| messageElement.innerHTML = ""; |
| let docLinks = []; |
| - for (let link of notification.links) |
| - docLinks.push(Utils.getDocLink(link)); |
| + if ("links" in notification) |
|
Wladimir Palant
2014/07/09 18:51:46
How about |if (notification.links)| just in case t
saroyanm
2014/07/09 18:57:25
Good point.
|
| + for (let link of notification.links) |
| + docLinks.push(Utils.getDocLink(link)); |
| + |
| insertMessage(messageElement, texts.message, docLinks); |
| messageElement.addEventListener("click", function(event) |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
