chrome/skin/devToolsOverlay.css - Issue 5765003219042304: EEH inspector integration fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: chrome/skin/devToolsOverlay.css

Issue 5765003219042304: EEH inspector integration fix (Closed)

Left Patch Set: Fix for light DevTools theme Created April 15, 2014, 10:12 a.m.

Right Patch Set: Nits fixes Created April 15, 2014, 1:53 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This Source Code is subject to the terms of the Mozilla Public License	2 * This Source Code is subject to the terms of the Mozilla Public License

3 * version 2.0 (the "License"). You can obtain a copy of the License at	3 * version 2.0 (the "License"). You can obtain a copy of the License at

4 * http://mozilla.org/MPL/2.0/.	4 * http://mozilla.org/MPL/2.0/.

5 */	5 */

6	6

7 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");	7 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");

8	8

9 #inspector-abp-elemhide-toolbutton>image	9 #ehh-inspector-toolbarbutton > image
Wladimir Palant 2014/04/15 13:38:19 Nit: please add a space before and after > here (I Nit: please add a space before and after > here (I wrote it down without spaces in the review comment for readability, not because that's our usual style). saroyanm 2014/04/15 13:54:43 Done. Show quoted text On 2014/04/15 13:38:19, Wladimir Palant wrote: > Nit: please add a space before and after > here (I wrote it down without spaces > in the review comment for readability, not because that's our usual style). Done.
10 {	10 {

11 filter: none;	11 filter: none;

	12 list-style-image: url("chrome://adblockplus/skin/abp-status-16.png");

	13 -moz-image-region: rect(0px, 16px, 16px, 0px);
	Wladimir Palant 2014/04/15 14:03:36 We should not go down into the anonymous elements We should not go down into the anonymous elements unless necessary - list-style-image and -moz-image-region should still be applied to #ehh-inspector-toolbarbutton itself. filter property is the only exception, there we cannot do it better.
12 }	14 }
Wladimir Palant 2014/04/15 13:38:19 We should also define list-style-image and other s We should also define list-style-image and other styles for #inspector-abp-elemhide-toolbarbutton here - if we have a proper stylesheet we shouldn't use inline styles. saroyanm 2014/04/15 13:54:43 Good point! Show quoted text On 2014/04/15 13:38:19, Wladimir Palant wrote: > We should also define list-style-image and other styles for > #inspector-abp-elemhide-toolbarbutton here - if we have a proper stylesheet we > shouldn't use inline styles. Good point!
LEFT	RIGHT