EEH inspector integration fix

lib/inspectorObserver.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 let InspectorObserver =
 {
   init: function()
   {
@@ skipping 28 matching lines @@
 
   inspectorReady: function(eventName, toolbox, panel)
   {
     let panelWindow = panel.panelWin;
     let inspectBtn = panelWindow.document.getElementById("inspector-breadcrumbs");
     if (!inspectBtn)
       return;
 
     let tooltiptext = InspectorObserver.inspectorButtonTooltip;
     button = panelWindow.document.createElement("toolbarbutton");
-    button.setAttribute("id", "inspector-abp-elemhide-toolbutton");

[Wladimir Palant, 2014/04/15 13:38:19]

Nit: I'm not sure why we use that weird id here, I think it was originally
generated by the DevTools API. Maybe change that into
ehh-inspector-toolbarbutton while you are at it?

[saroyanm, 2014/04/15 13:54:43]

Done.

-    button.style.listStyleImage = "url('chrome://adblockplus/skin/abp-status-16.png')";
-    button.style.MozImageRegion = "rect(0px, 16px, 16px, 0px)";
-    button.style.paddingTop = "4px";
+    button.setAttribute("id", "ehh-inspector-toolbarbutton");
     button.setAttribute("class", "devtools-toolbarbutton");
     button.setAttribute("tooltiptext", tooltiptext);
     button.setAttribute("tabindex", "0");
     button.addEventListener("command", function()
     {
       panelWindow.openDialog("chrome://elemhidehelper/content/composer.xul", "_blank",
                              "chrome,centerscreen,resizable,dialog=no", panel.selection.node);
     }, false);
     
     //Override button style for light DevTools theme
-    let style = panelWindow.document.createProcessingInstruction("xml-stylesheet", 'class="elemhidehelper-node" href="chrome://elemhidehelper/skin/devToolsOverlay.css" type="text/css"');

[Wladimir Palant, 2014/04/15 13:38:19]

Nit: class attribute is unnecessary if we aren't going to remove that
stylesheet.

[saroyanm, 2014/04/15 13:54:43]

Done.

+    let style = panelWindow.document.createProcessingInstruction("xml-stylesheet", 'href="chrome://elemhidehelper/skin/devToolsOverlay.css" type="text/css"');
     panelWindow.document.insertBefore(style, panelWindow.document.firstChild);
     
     inspectBtn.parentNode.insertBefore(button, inspectBtn);
   }
 };
 
 InspectorObserver.init();