Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 5823470080360448: Set the branding via confvars.sh (Closed)
Patch Set: Created Jan. 26, 2015, 3:10 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mobile/android/confvars.sh » ('j') | mobile/android/confvars.sh » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
===================================================================
--- a/README.md
+++ b/README.md
@@ -6,15 +6,5 @@
Building
--------
-Follow Mozilla's [Building Fennec](https://wiki.mozilla.org/Mobile/Fennec/Android)
-guide, setting up your _.mozconfig_ as follows:
-
- ac_add_options --with-android-ndk="$ANDROID_NDK_ROOT"
- ac_add_options --with-android-sdk="$ANDROID_HOME/platforms/android-19"
-
- # android options
- ac_add_options --enable-application=mobile/android
- ac_add_options --target=arm-linux-androideabi
-
- # branding
- ac_add_options --with-branding=mobile/android/branding/adblockbrowser
+Follow Mozilla's
René Jeschke 2015/02/18 14:52:30 Is this newline really needed here?
Felix Dahlke 2015/02/18 15:02:28 Yeah, to stick to 80 columns, I'm usually putting
René Jeschke 2015/02/18 15:07:26 How about: Follow Mozilla's [Building Fennec][] gu
Felix Dahlke 2015/02/18 15:14:42 Done. Wasn't aware that's possible, woohoo :D
+[Building Fennec](https://wiki.mozilla.org/Mobile/Fennec/Android) guide.
« no previous file with comments | « no previous file | mobile/android/confvars.sh » ('j') | mobile/android/confvars.sh » ('J')

Powered by Google App Engine
This is Rietveld