Issue 616 - Add $generichide + $genericblock filter options and enforce them.

lib/filterClasses.js

Index: lib/filterClasses.js
diff --git a/lib/filterClasses.js b/lib/filterClasses.js
index 1932a6895b6b4d15897d2a104d416be74e2bd80a..bfee06f62020a707b57869a2e22184544311ffc0 100644
--- a/lib/filterClasses.js
+++ b/lib/filterClasses.js
@@ -478,6 +478,16 @@ ActiveFilter.prototype =
   },
 
   /**
+   * Checks whether this filter is generic or specific
+   * @return {Boolean} true if filter is generic, otherwise false
+   */
+  isGeneric: function() /**Boolean*/

[Thomas Greiner, 2015/08/28 10:28:24]

Detail: Documentation is great but please avoid duplication.

[kzar, 2015/09/03 12:37:02]

I'm not sure where the duplication is here, but I'm open to suggestions if
there's something that you'd like to change.

[Thomas Greiner, 2015/09/21 16:53:36]

The duplication I meant is that you specify the return type both in the comment
block above as well as inline on this line.

[kzar, 2015/09/22 13:16:47]

I see, Done.

+  {
+    return (!(this.sitekeys && this.sitekeys.length) &&
+            (!this.domains || this.domains[""]));
+  },
+
+  /**
    * See Filter.serialize()
    */
   serialize: function(buffer)
@@ -754,11 +764,18 @@ RegExpFilter.typeMap = {
   BACKGROUND: 4,    // Backwards compat, same as IMAGE
 
   POPUP: 0x10000000,
-  ELEMHIDE: 0x40000000
+  GENERICBLOCK: 0x20000000,
+  ELEMHIDE: 0x40000000,
+  GENERICHIDE: 0x80000000
 };
 
-// DOCUMENT, ELEMHIDE, POPUP options shouldn't be there by default
-RegExpFilter.prototype.contentType &= ~(RegExpFilter.typeMap.DOCUMENT | RegExpFilter.typeMap.ELEMHIDE | RegExpFilter.typeMap.POPUP);
+// DOCUMENT, ELEMHIDE, POPUP, GENERICHIDE and GENERICBLOCK options shouldn't
+// be there by default
+RegExpFilter.prototype.contentType &= ~(RegExpFilter.typeMap.DOCUMENT |
+                                        RegExpFilter.typeMap.ELEMHIDE |
+                                        RegExpFilter.typeMap.POPUP |
+                                        RegExpFilter.typeMap.GENERICHIDE |
+                                        RegExpFilter.typeMap.GENERICBLOCK);
 
 /**
  * Class for blocking filters