Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/common.js

Issue 5867629902299136: Fixed various issues in older Chrome versions (Closed)
Left Patch Set: Created Dec. 19, 2013, 10:24 a.m.
Right Patch Set: Created Dec. 19, 2013, 10:46 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « chrome/background.js ('k') | popup.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 sender.tab = new Tab(sender.tab); 74 sender.tab = new Tab(sender.tab);
75 return listener(message, sender, sendResponse); 75 return listener(message, sender, sendResponse);
76 }; 76 };
77 } 77 }
78 }; 78 };
79 79
80 80
81 /* API */ 81 /* API */
82 82
83 ext = { 83 ext = {
84 backgroundPage: {}, 84 backgroundPage: {
85 getWindow: function()
86 {
87 return chrome.extension.getBackgroundPage();
88 }
89 },
85 getURL: chrome.extension.getURL, 90 getURL: chrome.extension.getURL,
86 onMessage: new MessageEventTarget(), 91 onMessage: new MessageEventTarget(),
87 i18n: chrome.i18n 92 i18n: chrome.i18n
88 }; 93 };
89 94
90 if ("runtime" in chrome && "sendMessage" in chrome.runtime) 95 if ("runtime" in chrome && "sendMessage" in chrome.runtime)
91 ext.backgroundPage.sendMessage = chrome.runtime.sendMessage; 96 ext.backgroundPage.sendMessage = chrome.runtime.sendMessage;
92 else if ("sendMessage" in chrome.extension) 97 else if ("sendMessage" in chrome.extension)
93 ext.backgroundPage.sendMessage = chrome.extension.sendMessage; 98 ext.backgroundPage.sendMessage = chrome.extension.sendMessage;
94 else 99 else
95 ext.backgroundPage.sendMessage = chrome.extension.sendRequest; 100 ext.backgroundPage.sendMessage = chrome.extension.sendRequest;
96
97 try
Sebastian Noack 2013/12/19 10:38:59 I would prefer to wrap chrome.extension.getBackgro
Wladimir Palant 2013/12/19 10:47:17 True, that's a better solution - done.
98 {
99 ext.backgroundPage.getWindow = chrome.extension.getBackgroundPage;
100 }
101 catch (e)
102 {
103 // This exception is expected in content scripts in older Chrome versions.
104 }
105 })(); 101 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld