Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/ext/common.js

Issue 6098518317989888: Fix: Notification popup is broken (Closed)
Patch Set: Linux issue and minor changes Created Feb. 18, 2014, 4:16 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« background.js ('K') | « background.js ('k') | metadata.chrome » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/ext/common.js
===================================================================
--- a/chrome/ext/common.js
+++ b/chrome/ext/common.js
@@ -112,4 +112,8 @@
ext.backgroundPage.sendMessage = chrome.extension.sendMessage;
else
ext.backgroundPage.sendMessage = chrome.extension.sendRequest;
+
+ // Chrome on Linux, not fully support chrome.notifications ( https://code.google.com/p/chromium/issues/detail?id=291485 )
Thomas Greiner 2014/02/18 16:44:25 Grammar nit: Chrome on Linux does not fully suppor
saroyanm 2014/02/18 17:53:48 oops.
+ if ("notifications" in chrome && navigator.platform.indexOf("Linux") == -1)
+ ext.notifications = chrome.notifications;
})();
« background.js ('K') | « background.js ('k') | metadata.chrome » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld