Issue 1181 - Change polyfill for IE8 (fix settings page)

html/static/js/ieEventListenerPolyfill.js

 if (typeof window.addEventListener != "function")
 {
   window.addEventListener = function(type, handler, capture)
   {
     this.attachEvent("on" + type, handler)
   };
 }
 
 if (typeof window.removeEventListener != "function")
 {
   window.removeEventListener = function(type, handler)
   {
     this.detachEvent("on" + type, handler)
   };
 }
 
 if (typeof Element.prototype.addEventListener != "function")

[Felix Dahlke, 2014/08/08 13:58:35]

My question remains: Is this still necessary to fix things in IE8? We use
window.addEventListener everywhere explicitly from what I can tell.

[Oleksandr, 2014/08/08 14:05:17]

Oh, I miss understood you before then. Yes, it is necessary. We are not using
window.addEventListener everywhere, we also use addEventListener on elements.
Like an event listener for subscriptions combo box, or a AA checkbox or a button
to manage domains (IESettings.js).


On 2014/08/08 13:58:35, Felix H. Dahlke wrote:

[Felix Dahlke, 2014/08/08 14:07:01]

Ah, I see! Misunderstanding then.

 {
-  Element.prototype.addEventListener = function(type, handler, capture)

[Felix Dahlke, 2014/08/08 14:07:01]

Can we assign this to window.addEventListener, and removeEventListener below
respectively?

-  {
-    this.attachEvent("on" + type, handler)
-  };
+  Element.prototype.addEventListener = window.addEventListener;

[Oleksandr, 2014/08/08 14:19:34]

Looks like we've tried every combination now :)

[Felix Dahlke, 2014/08/08 14:21:12]

Yes, I like this one best :)

 }
 
 if (typeof Element.prototype.removeEventListener != "function")
 {
-  Element.prototype.removeEventListener = function(type, handler)
-  {
-    this.detachEvent("on" + type, handler)
-  };
+  Element.prototype.removeEventListener = window.removeEventListener;
 }