Make the Acceptable Ads link clickable

jni/abpEngine.cpp

Index: jni/abpEngine.cpp
===================================================================
--- a/jni/abpEngine.cpp
+++ b/jni/abpEngine.cpp
@@ -41,6 +41,8 @@
   JNIEXPORT void JNICALL Java_org_adblockplus_android_ABPEngine_refreshSubscription(JNIEnv *pEnv, jobject, jstring url);
   JNIEXPORT void JNICALL Java_org_adblockplus_android_ABPEngine_actualizeSubscriptionStatus(JNIEnv *pEnv, jobject, jstring url);
   JNIEXPORT void JNICALL Java_org_adblockplus_android_ABPEngine_setAcceptableAdsEnabled(JNIEnv *pEnv, jobject, jboolean enabled);
+  JNIEXPORT jstring JNICALL Java_org_adblockplus_android_ABPEngine_getDocumentationLink(
+      JNIEnv *env, jobject object);
   JNIEXPORT jboolean JNICALL Java_org_adblockplus_android_ABPEngine_matches(JNIEnv *pEnv, jobject, jstring url, jstring contentType, jstring documentUrl);
   JNIEXPORT jobjectArray JNICALL Java_org_adblockplus_android_ABPEngine_getSelectorsForDomain(JNIEnv *pEnv, jobject, jstring domain);
   JNIEXPORT void JNICALL Java_org_adblockplus_android_ABPEngine_checkUpdates(JNIEnv *pEnv, jobject);
@@ -455,6 +457,13 @@
   }
 }
 
+JNIEXPORT jstring JNICALL Java_org_adblockplus_android_ABPEngine_getDocumentationLink(
+    JNIEnv *env, jobject object)

[Wladimir Palant, 2013/11/26 10:48:57]

This is a fairly useless API. It would make more sense to either expose
FilterEngine::GetPref() (obviously complicated because multiple return types are
possible) or the equivalent of Utils.getDocLink() JavaScript function (currently
implemented in adblockplus and adblockpluschrome repositories). Implementing the
latter in JavaScript would require a change to libadblockplus (the change itself
is trivial, updating libadblockplus binaries unfortunately isn't). Alternatively
the locale parameter could be cached in the init function and reused in the C++
code here.

[Felix Dahlke, 2013/11/26 13:11:46]

Yeah, I agree that it makes sense to expose something better here, I favour
Utils.getDocLink(). But that does indeed require a libadblockplus change, I'll
create a follow-up for it.

+{
+  const std::string documentationLink = filterEngine->GetPref("documentation_link")->AsString();
+  return env->NewStringUTF(documentationLink.c_str());
+}
+
 JNIEXPORT jboolean JNICALL Java_org_adblockplus_android_ABPEngine_matches(JNIEnv *pEnv, jobject, jstring url, jstring contentType, jstring documentUrl)
 {
   try