Make the Acceptable Ads link clickable

src/org/adblockplus/android/Preferences.java

Index: src/org/adblockplus/android/Preferences.java
===================================================================
--- a/src/org/adblockplus/android/Preferences.java
+++ b/src/org/adblockplus/android/Preferences.java
@@ -45,6 +45,7 @@
 import android.preference.PreferenceManager;
 import android.text.Html;
 import android.text.format.DateFormat;
+import android.text.method.LinkMovementMethod;
 import android.util.Log;
 import android.view.View;
 import android.view.ViewGroup;
@@ -151,8 +152,15 @@
 
     if (firstRun && current != null)
     {
-      new AlertDialog.Builder(this).setTitle(R.string.app_name)
-          .setMessage(String.format(getString(R.string.msg_subscription_offer, current.title)))
+      final String message = String.format(getString(R.string.msg_subscription_offer, current.title))
+          .replace("<a>", "<a href=\"" + getString(R.string.acceptable_ads_url) + "\">");

[Wladimir Palant, 2013/11/26 09:35:54]

This is a security vulnerability, please don't allow localizers to inject random
HTML tags into our UI. You need to escape entities in the string and then
replace &lt;a&gt;(.*?)&lt;/a&gt; by <a href="...">\1</a> - like we do it in
Firefox or Chrome. Note that HTML entities need to be escaped in the URL you
insert as well. The right function to do this seems to be
android.text.TextUtils.htmlEncode().

[Felix Dahlke, 2013/11/26 10:25:50]

Done. I had a feeling I wouldn't get away with this... :)

+      final TextView messageView = new TextView(this);
+      messageView.setText(Html.fromHtml(message));
+      messageView.setMovementMethod(LinkMovementMethod.getInstance());
+      final int padding = 10;

[Felix Dahlke, 2013/11/26 09:21:52]

I'm not a big fan of hard coding style properties, but I think the only
alternative would be to have a proper xml-defined dialog. I'd rather do that in
a follow-up.

+      messageView.setPadding(padding, padding, padding, padding);
+      new AlertDialog.Builder(this).setTitle(R.string.install_name)
+          .setView(messageView)
           .setIcon(android.R.drawable.ic_dialog_info)
           .setPositiveButton(R.string.ok, null).create().show();
     }