[IE] Replace ATL::CRect

src/plugin/PluginClass.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginClass.h"
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #ifdef SUPPORT_FILTER
 #include "PluginFilter.h"
 #endif
 #include "PluginMimeFilterClient.h"
 #include "PluginClient.h"
@@ skipping 34 matching lines @@
 CComAutoCriticalSection CPluginClass::s_criticalSectionLocal;
 CComAutoCriticalSection CPluginClass::s_criticalSectionBrowser;
 CComAutoCriticalSection CPluginClass::s_criticalSectionWindow;
 
 CComQIPtr<IWebBrowser2> CPluginClass::s_asyncWebBrowser2;
 
 #ifdef SUPPORT_WHITELIST
 std::map<UINT,std::wstring> CPluginClass::s_menuDomains;
 #endif
 
+//-------------------------------------------------------
+// Rectangle
+//-------------------------------------------------------
 
+namespace {

[Oleksandr, 2014/07/09 19:29:08]

Nit: New line before {

+  // Without an extra namespace within the anonymous one, the identifier "Rectangle" is ambiguous

[Felix Dahlke, 2014/07/10 04:49:03]

Hm, guess it conflicts with this one?

http://msdn.microsoft.com/en-us/library/windows/desktop/dd162898%28v=vs.85%29...

How about calling our class "Rect" or something instead?

[Eric, 2014/07/23 11:25:05]

FYI. This URL is exhibited a defect in the code review software. The left and
right parentheses are first getting quoted to "percent-28" and "percent-29",
then the percent symbols are getting quoted to "percent-25". Manually editing
the URL brings it back to working.

[Eric, 2014/07/23 12:03:18]

Well, the base class is "RECT", and it doesn't seem wise to make it differ only
in case.

Instead, I just changed the namespace to AdblockPlus. In case we ever need a
library-quality version of this class, this is likely to be its first name.

+  namespace Local {

[Oleksandr, 2014/07/09 19:29:08]

Nit: New line before {

+    /**
+     * Replacement for ATL type CRect.
+     */
+    class Rectangle
+      : public RECT
+    {
+    public:
+      // C++11 noexcept

[Felix Dahlke, 2014/07/10 04:49:03]

I guess you're marking this so we can make it noexcept later? Trouble is, it
seems like VS 2013 won't support noexcept, I don't think we should have markers
like this everywhere until we upgrade to a VS version that supports it. Let's
rather see what can be made noexcept once we can use it.

[Eric, 2014/07/23 11:25:05]

Yes.
Unfortunately, no, it doesn't. I was just reading up on this yesterday.
http://msdn.microsoft.com/en-us/library/hh567368.aspx
The trouble with that policy is that it means reanalyzing the code from scratch,
as a whole, in a year or two. If we leave comments in place, it's a simple
search-and-replace later, much faster and more effective.

In addition, the comment acts as documentation until then.

+      inline int Height() const

[Felix Dahlke, 2014/07/10 04:49:03]

inline is redundant here, since this will only be defined in one compilation
unit. And inline member functions are implicitly inline anyway.

+      {
+        return bottom - top;
+      }
+
+      // C++11 noexcept
+      inline int Width() const
+      {
+        return right - left;
+      }
+    };
+  }
+}
+
+//-------------------------------------------------------
+// CPluginClass

[Felix Dahlke, 2014/07/10 04:49:03]

We don't do class headers like this usually, I personally think it's just noise.
Oleksandr, what do you think?

[Oleksandr, 2014/07/14 07:56:21]

Visually I think it makes sense, and sometimes it's easier to get the code
structure. But let's remove these for consistency with the rest of the code.

On 2014/07/10 04:49:03, Felix H. Dahlke wrote:

+//-------------------------------------------------------
 CPluginClass::CPluginClass()
 {
   //Use this line to debug memory leaks
   //    _CrtDumpMemoryLeaks();
 
   m_isAdviced = false;
   m_nConnectionID = 0;
   m_hTabWnd = NULL;
   m_hStatusBarWnd = NULL;
   m_hPaneWnd = NULL;
@@ skipping 876 matching lines @@
     hWnd = ::GetWindow(hWnd, GW_HWNDNEXT);
   }
 
   if (!hWndStatusBar)
   {
     DEBUG_ERROR_LOG(0, PLUGIN_ERROR_UI, PLUGIN_ERROR_UI_NO_STATUSBAR_WIN, L"Class::CreateStatusBarPane - No status bar")
     return true;
   }
 
   // Calculate pane height
-  CRect rcStatusBar;
+  Local::Rectangle rcStatusBar;
   ::GetClientRect(hWndStatusBar, &rcStatusBar);
 
   if (rcStatusBar.Height() > 0)
   {
 #ifdef _DEBUG
     m_nPaneWidth = 70;
 #else
     m_nPaneWidth = min(rcStatusBar.Height(), 22);
 #endif
   }
@@ skipping 591 matching lines @@
       HLOCAL hLocal = LocalAlloc(LHND, sizeof(int) * (nParts+1));
       LPINT lpParts = (LPINT)LocalLock(hLocal);
       memcpy(lpParts, (void*)lParam, wParam*sizeof(int));
 
       for (unsigned i = 0; i < STATUSBAR_PANE_NUMBER; i++)
       {
         lpParts[i] -= pClass->m_nPaneWidth;
       }
       LRESULT hRet = CallWindowProc(pClass->m_pWndProcStatus, hWnd, message, wParam, (LPARAM)lpParts);
 
-      CRect rcPane;
+      Local::Rectangle rcPane;
       ::SendMessage(hWnd, SB_GETRECT, STATUSBAR_PANE_NUMBER, (LPARAM)&rcPane);
 
-      CRect rcClient;
+      Local::Rectangle rcClient;
       ::GetClientRect(hWnd, &rcClient);
 
       ::MoveWindow(
         pClass->m_hPaneWnd,
         lpParts[STATUSBAR_PANE_NUMBER] - pClass->m_nPaneWidth,
         0,
         pClass->m_nPaneWidth,
         rcClient.Height(),
         TRUE);
 
@@ skipping 66 matching lines @@
   case WM_SETCURSOR:
     {
       ::SetCursor(::LoadCursor(NULL, IDC_ARROW));
       return TRUE;
     }
   case WM_PAINT:
     {
       PAINTSTRUCT ps;
       HDC hDC = ::BeginPaint(hWnd, &ps);
 
-      CRect rcClient;
+      Local::Rectangle rcClient;
       ::GetClientRect(hWnd, &rcClient);
 
       int nDrawEdge = 0;
 
       // Old Windows background drawing
       if (pClass->m_hTheme == NULL)
       {
         ::FillRect(hDC, &rcClient, (HBRUSH)(COLOR_BTNFACE + 1));
         ::DrawEdge(hDC, &rcClient, BDR_RAISEDINNER, BF_LEFT);
 
         nDrawEdge = 3;
         rcClient.left += 3;
 
         ::DrawEdge(hDC, &rcClient, BDR_SUNKENOUTER, BF_RECT);
       }
       // Themed background drawing
       else
       {
         // Draw background
         if (pfnDrawThemeBackground)
         {
-          CRect rc = rcClient;
+          Local::Rectangle rc = rcClient;
           rc.right -= 2;
           pfnDrawThemeBackground(pClass->m_hTheme, hDC, 0, 0, &rc, NULL);
         }
 
         // Copy separator picture to left side
         int nHeight = rcClient.Height();
         int nWidth = rcClient.Width() - 2;
 
         for (int i = 0; i < 2; i++)
         {
@@ skipping 19 matching lines @@
         if (hIcon)
         {
           ::DrawIconEx(hDC, offx, (rcClient.Height() - 16)/2 + 2, hIcon, 16, 16, NULL, NULL, DI_NORMAL);
           offx += 22;
         }
 #ifdef _DEBUG
         // Display version
         HFONT hFont = (HFONT)::SendMessage(pClass->m_hStatusBarWnd, WM_GETFONT, 0, 0);
         HGDIOBJ hOldFont = ::SelectObject(hDC,hFont);
 
-        CRect rcText = rcClient;
+        Local::Rectangle rcText = rcClient;
         rcText.left += offx;
         ::SetBkMode(hDC, TRANSPARENT);
         ::DrawTextW(hDC, IEPLUGIN_VERSION, -1, &rcText, DT_WORD_ELLIPSIS|DT_LEFT|DT_SINGLELINE|DT_VCENTER);
 
         ::SelectObject(hDC, hOldFont);
 #endif // _DEBUG
       }
 
       // Done!
       EndPaint(hWnd, &ps);
@@ skipping 229 matching lines @@
         }
       }
     }
 
     hTabWnd = ::GetWindow(hTabWnd, GW_HWNDNEXT);
   }
 
   return hTabWnd;
 
 }