common/src/Registry.cpp - Issue 6216090891845632: Issue #404 - Create common library shared between plugin/engine and installer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: common/src/Registry.cpp

Issue 6216090891845632: Issue #404 - Create common library shared between plugin/engine and installer (Closed)

Patch Set: Created Jan. 9, 2015, 8:07 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 #include "Registry.h"	1 #include "Registry.h"

2 #include <memory>	2 #include <memory>

3	3

4 using namespace AdblockPlus;	4 using namespace AdblockPlus;

5	5

6 RegistryKey::RegistryKey(HKEY parent, const std::wstring& key_name)	6 RegistryKey::RegistryKey(HKEY parent, const std::wstring& key_name)

7 {	7 {

8 if (key_name.empty())	8 if (key_name.empty())

9 {	9 {

10 throw std::runtime_error("key_name may not be empty");	10 throw std::runtime_error("key_name may not be empty");

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
61 * If so, we have to decrement the length of the return value to eliminate it.	61 * If so, we have to decrement the length of the return value to eliminate it.

62 * If it persists, it will interfere with later string operations such as conc atenation.	62 * If it persists, it will interfere with later string operations such as conc atenation.

63 */	63 */

64 if (p[psize - 1] == L'\0')	64 if (p[psize - 1] == L'\0')

65 {	65 {

66 --psize;	66 --psize;

67 }	67 }

68 return std::wstring(p.get(), psize);	68 return std::wstring(p.get(), psize);

69 }	69 }

70	70

OLD	NEW