Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include.postload.js

Issue 6217022228660224: Issue 1864 - Fixed error caused when generated filters match hidden elements (Closed)
Patch Set: Created Jan. 23, 2015, 4:27 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include.postload.js
===================================================================
--- a/include.postload.js
+++ b/include.postload.js
@@ -56,6 +56,11 @@
{
var overlay = addElementOverlay(element);
+ // If the element isn't displayed no overlay will be added.
+ // Moreover, we don't need to highlight anything then.
+ if (!overlay)
+ return;
+
highlightElement(overlay, shadowColor, backgroundColor);
overlay.style.pointerEvents = "none";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld