Issue #1686 - Kill iexplore.exe and AdblockplusEngine.exe processes from the installer

installer/src/installer-lib/process.cpp

 #include <stdexcept>
 #include <functional>
 #include <wctype.h>
 // <thread> is C++11, but implemented in VS2012
 #include <thread>
 
 #include "installer-lib.h"
 #include "process.h"
 #include "handle.h"
 #include "session.h"
@@ skipping 260 matching lines @@
     case 3 :
       {
         /*
         * Send WM_CLOSE to every admissible window.
         */
         send_message m( WM_CLOSE, 0, 0 ) ;
         iterate_our_windows( m ) ;
       }
       break ;
 
     default :

[Eric, 2015/03/13 16:49:48]

This should be "case 4 :" and we should retain the previous "default:". The
reason is that we want to execute the wait loop below to give the system some
time to finish terminating the process.

We don't want a false negative because of a zombie process that exists longer
than normal.

       /*
-      * We're out of ways to try to shut down.
+      * We're out of ways to try to shut down. Oh well. Take cover. It gets violent here.

[Eric, 2015/03/13 16:49:48]

Good comment.

       */
-      return false ;
+      for (auto it = pid_set.begin(); it != pid_set.end(); ++it)
+      {
+        HANDLE tmpHandle = OpenProcess(PROCESS_TERMINATE, FALSE, *it);
+        if (tmpHandle != NULL)

[Eric, 2015/03/13 16:49:48]

We can use implicit conversion to bool here.

I would use "if (!tmpHandle) continue;", but that's just me.

+        {
+          Windows_Handle procHandle(tmpHandle);
+          TerminateProcess(tmpHandle, 0);
+        }
+      }
+      Refresh();
+
+      return !IsRunning() ;
     }
 
     /*
     * Wait loop.
     */
     for ( unsigned int j = 0 ; j < 50 ; ++ j )
     {
-      std::this_thread::sleep_for( std::chrono::milliseconds( 100 ) ) ;
+      std::this_thread::sleep_for( std::chrono::milliseconds( 30 ) ) ;

[sergei, 2015/04/02 08:04:09]

no spaces?

       Refresh() ;
       if ( ! IsRunning() )
       {
         return true ;
       }
     }
     // Assert is_running()
   }
   // No control path leaves the for-loop.
 } ;