disable acceptable ads from first run page

lib/appSupport.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 898 matching lines @@
       menuItem = window.NativeWindow.menu.add(actionText, iconUrl, toggleWhitelist.bind(null, window));
     };
 
     UI.openSubscriptionDialog = function(window, url, title, mainURL, mainTitle)
     {
       let dialogTitle = this.overlay.attributes.subscriptionDialogTitle;
       let dialogMessage = this.overlay.attributes.subscriptionDialogMessage.replace(/\?1\?/, title).replace(/\?2\?/, url);
       if (Utils.confirm(window, dialogMessage, dialogTitle))
         this.setSubscription(url, title);
     };
+    
+    UI.openFiltersDialog = function()
+    {
+      let window = this.currentWindow;

[Wladimir Palant, 2014/05/02 11:50:00]

Please use UI.currentWindow explicitly - it wasn't really obvious to me what
"this" means here.

[saroyanm, 2014/05/02 14:07:27]

Done.

+      if (!window)
+        return
+      
+      let browser = window.BrowserApp.addTab("about:addons").browser;

[Wladimir Palant, 2014/05/02 11:50:00]

How about:

  let browser = exports.addTab(window, "about:addons").browser;

That function is defined above, this way you won't duplicate its code. Also, it
will automatically select the new tab.

[saroyanm, 2014/05/02 14:07:27]

Sorry for not being attentive on that..

+      browser.addEventListener("load", function openAddonPrefs(event) 
+      {
+        browser.removeEventListener("load", openAddonPrefs, true);
+        browser._contentWindow.setTimeout(function()

[saroyanm, 2014/05/02 11:18:30]

Couldn't find better approach while aboutAddons.js using
window.addEventListener("load", init, false);
to add popstate event in init method.

[Wladimir Palant, 2014/05/02 11:50:00]

Yes, you need to run this immediately after the page processes the "load" event.
Please use Utils.runAsync() for that rather than using random timeout values.

[saroyanm, 2014/05/02 14:07:27]

Thanks for pointing on the method, gave me understanding behind threadManagement
in FF.

+        {
+          let event = new Event("Event");
+          event.initEvent("popstate", true, false);
+          event.state = {id: require("info").addonID};
+          browser._contentWindow.dispatchEvent(event);
+        }, 200);
+      }, true);

[Wladimir Palant, 2014/05/02 11:50:00]

I don't really see a point for having a capturing event listener here, won't it
also work if you use addEventListener("load", ..., false)?

[saroyanm, 2014/05/02 14:07:27]

Yes actually It will not be triggered, not sure why, no success on understanding
the case.
The only thing I've noticed most of the load events attached to browser for
mobile FF are using UseCapture param set to true:
http://mxr.mozilla.org/mobile-browser/search?string=addEventListener%28%22loa...

https://developer.mozilla.org/en-US/Add-ons/Firefox_for_Android/Code_snippets...

+    };
 
     break;
   }
 }