Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/requestNotifier.js

Issue 6305806509146112: Issue 427 - Remove non-standard function and getter syntax (Closed)
Left Patch Set: Convert shorthand function expressions to arrow functions, this of course isn't possible for getter… Created May 10, 2014, 12:43 p.m.
Right Patch Set: Wow sorry for those wrong braces, I am so used to a different style that I didn't even realize what… Created May 18, 2014, 10:51 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/io.js ('k') | lib/subscriptionClasses.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 location: null, 341 location: null,
342 /** 342 /**
343 * Filter that was applied to this request (if any) 343 * Filter that was applied to this request (if any)
344 * @type Filter 344 * @type Filter
345 */ 345 */
346 filter: null, 346 filter: null,
347 /** 347 /**
348 * String representation of the content type, e.g. "subdocument" 348 * String representation of the content type, e.g. "subdocument"
349 * @type String 349 * @type String
350 */ 350 */
351 get typeDescr() { return require("contentPolicy").Policy.typeDescr[this.type]; }, 351 get typeDescr()
Wladimir Palant 2014/05/15 07:12:38 Nit: Please add proper line breaks here.
352 {
353 return require("contentPolicy").Policy.typeDescr[this.type];
354 },
352 /** 355 /**
353 * User-visible localized representation of the content type, e.g. "frame" 356 * User-visible localized representation of the content type, e.g. "frame"
354 * @type String 357 * @type String
355 */ 358 */
356 get localizedDescr() { return require("contentPolicy").Policy.localizedDescr[t his.type]; }, 359 get localizedDescr()
Wladimir Palant 2014/05/15 07:12:38 Nit: Please add proper line breaks here.
360 {
361 return require("contentPolicy").Policy.localizedDescr[this.type];
362 },
357 363
358 /** 364 /**
359 * Attaches this request object to a DOM node. 365 * Attaches this request object to a DOM node.
360 */ 366 */
361 attachToNode: function(/**Node*/ node) 367 attachToNode: function(/**Node*/ node)
362 { 368 {
363 let existingData = getEntry(nodeData, node); 369 let existingData = getEntry(nodeData, node);
364 if (typeof existingData == "undefined") 370 if (typeof existingData == "undefined")
365 { 371 {
366 existingData = {}; 372 existingData = {};
367 setEntry(nodeData, node, existingData); 373 setEntry(nodeData, node, existingData);
368 } 374 }
369 375
370 // Add this request to the node data 376 // Add this request to the node data
371 existingData[this.type + " " + this.location] = this; 377 existingData[this.type + " " + this.location] = this;
372 } 378 }
373 }; 379 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld