Unified Diff: lib/utils.js
Issue 6305806509146112:
Issue 427 - Remove non-standard function and getter syntax (Closed)
Patch Set: Convert shorthand function expressions to arrow functions, this of course isn't possible for getter…
Created May 10, 2014, 12:43 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« lib/ui.js ('K')
|
« lib/ui.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/utils.js |
| =================================================================== |
| --- a/lib/utils.js |
| +++ b/lib/utils.js |
| @@ -50,17 +50,17 @@ let Utils = exports.Utils = |
| /** |
| * Returns whether we are running in Fennec, for Fennec-specific hacks |
| * @type Boolean |
| */ |
| get isFennec() |
| { |
| let {application} = require("info"); |
| let result = (application == "fennec" || application == "fennec2"); |
| - Utils.__defineGetter__("isFennec", function() result); |
| + Utils.__defineGetter__("isFennec", () => result); |
| return result; |
| }, |
| /** |
| * Returns the user interface locale selected for adblockplus chrome package. |
| */ |
| get appLocale() |
| { |
| @@ -68,27 +68,27 @@ let Utils = exports.Utils = |
| try |
| { |
| locale = Utils.chromeRegistry.getSelectedLocale("adblockplus"); |
| } |
| catch (e) |
| { |
| Cu.reportError(e); |
| } |
| - Utils.__defineGetter__("appLocale", function() locale); |
| + Utils.__defineGetter__("appLocale", () => locale); |
| return Utils.appLocale; |
| }, |
| /** |
| * Returns version of the Gecko platform |
| */ |
| get platformVersion() |
| { |
| let platformVersion = Services.appinfo.platformVersion; |
| - Utils.__defineGetter__("platformVersion", function() platformVersion); |
| + Utils.__defineGetter__("platformVersion", () => platformVersion); |
| return Utils.platformVersion; |
| }, |
| /** |
| * Retrieves a string from global.properties string bundle, will throw if string isn't found. |
| * |
| * @param {String} name string name |
| * @return {String} |
