Issue 2274 - Move notification parsing into a module

sitescripts/notifications/parser.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2015 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 import codecs
 import os
 import re
 import subprocess
 import tarfile
-import time
 import traceback
 from StringIO import StringIO
 
 from sitescripts.utils import get_config
 
 def _parse_targetspec(value, name):
   target = {}
   for spec in value.split():
     known = False
     for parameter in ("extension", "application", "platform"):
@@ skipping 54 matching lines @@
     raise Exception("No message for en-US (default language) in file '%s'" % name)
   return notification
 
 def load_notifications():
   repo = get_config().get("notifications", "repository")
   subprocess.call(["hg", "-R", repo, "pull", "-q"])
   command = ["hg", "-R", repo, "archive", "-r", "default", "-t", "tar",
       "-p", ".", "-X", os.path.join(repo, ".hg_archival.txt"), "-"]
   data = subprocess.check_output(command)
 
-  result = {"version": time.strftime("%Y%m%d%H%M", time.gmtime()), "notifications": []}
+  notifications = []
   with tarfile.open(mode="r:", fileobj=StringIO(data)) as archive:
     for fileinfo in archive:
       name = fileinfo.name
       if name.startswith("./"):
         name = name[2:]
 
       if fileinfo.type == tarfile.REGTYPE:
         data = codecs.getreader("utf8")(archive.extractfile(fileinfo))
         try:
           notification = _parse_notification(data, name)
           if "inactive" in notification:
             continue
-          result["notifications"].append(notification)
+          notifications.append(notification)
         except:
           traceback.print_exc()
-  return result
+  return notifications