Issue 424 - Anti-adblock filterlist disabled on extension update (Platform)

background.js

Index: background.js
===================================================================
--- a/background.js
+++ b/background.js
@@ -220,14 +220,17 @@
       addAcceptable = false;
   }
 
-  // Add "anti-adblock messages" subscription
-  var subscription = Subscription.fromURL(Prefs.subscriptions_antiadblockurl);
-  if (subscription)
+  // Add "anti-adblock messages" subscription for new users and users updating from old ABP versions
+  if (!prevVersion || parseFloat(prevVersion) < 1.8)

[Wladimir Palant, 2014/05/05 15:23:15]

Please use Services.vc.compare() here as well.

   {
-    subscription.disabled = true;
-    FilterStorage.addSubscription(subscription);
-    if (subscription instanceof DownloadableSubscription && !subscription.lastDownload)
-      Synchronizer.execute(subscription);
+    var subscription = Subscription.fromURL(Prefs.subscriptions_antiadblockurl);
+    if (subscription)

[Wladimir Palant, 2014/05/05 15:23:15]

As with the other review, this should be:

if (subscription && !(subscription.url in FilterStorage.knownSubscriptions))

+    {
+      subscription.disabled = true;
+      FilterStorage.addSubscription(subscription);
+      if (subscription instanceof DownloadableSubscription && !subscription.lastDownload)
+        Synchronizer.execute(subscription);
+    }
   }
 
   if (!addSubscription && !addAcceptable)