Unified Diff: popupBlocker.js
Issue 6346177440120832:
Added abstraction for frames, to fix domain-based rules, whitelisting and ad counter on Safari (Closed)
Patch Set: Rebased and addressed comments
Created Jan. 19, 2014, 10:40 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« chrome/ext/background.js ('K')
|
« popup.js ('k')
|
safari/ext/background.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: popupBlocker.js |
| =================================================================== |
| --- a/popupBlocker.js |
| +++ b/popupBlocker.js |
| @@ -22,10 +22,12 @@ |
| chrome.webNavigation.onCreatedNavigationTarget.addListener(function(details) |
| { |
| var sourceTab = new Tab({id: details.sourceTabId}); |
| - if (isFrameWhitelisted(sourceTab, details.sourceFrameId)) |
| + var sourceFrame = new Frame({id: details.sourceFrameId, tab: sourceTab}); |
| + |
| + if (isFrameWhitelisted(sourceTab, sourceFrame)) |
| return; |
| - var openerUrl = getFrameUrl(sourceTab, details.sourceFrameId); |
| + var openerUrl = sourceFrame.url; |
| if (!openerUrl) |
| { |
| // We don't know the opener tab |
« chrome/ext/background.js ('K')
|
« popup.js ('k')
|
safari/ext/background.js » ('j')
|
no next file with comments »
