Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/filters-filterview.js

Issue 6363941206753280: Issue 594 - Typo in preferences window tooltip for the slow filters column (Closed)
Patch Set: Created June 2, 2014, 9:09 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/filters-filterview.js
===================================================================
--- a/chrome/content/ui/filters-filterview.js
+++ b/chrome/content/ui/filters-filterview.js
@@ -24,16 +24,32 @@ Cu.import("resource://gre/modules/XPCOMU
*/
var FilterView =
{
/**
* Initialization function.
*/
init: function()
{
+ // "Manually" remove access key for col-slow tooltip, Utils.splitAllLabels()
+ // won't do it.
+ let slowColumn = document.getElementById("col-slow");
+ if (slowColumn)
+ {
+ for (let attr of ["display", "tooltiptext"])
+ {
+ let value = slowColumn.getAttribute(attr);
+ if (!value)
+ continue;
+ let [label, accessKey] = Utils.splitLabel(value);
+ if (label != value)
+ slowColumn.setAttribute(attr, label);
+ }
+ }
+
if (this.sortProcs)
return;
function compareText(/**Filter*/ filter1, /**Filter*/ filter2)
{
if (filter1.text < filter2.text)
return -1;
else if (filter1.text > filter2.text)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld