Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/icon.js

Issue 6445129351036928: Noissue - Fixed issue where JsDoc documented module functions incorrectly (Closed)
Patch Set: Created April 15, 2015, 3:52 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/filterValidation.js ('k') | lib/stats.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/icon.js
===================================================================
--- a/lib/icon.js
+++ b/lib/icon.js
@@ -93,31 +93,29 @@
* @param {Page} page The page to set the browser action icon for
* @param {Boolean} whitelisted Whether the page has been whitelisted
*/
-function updateIcon(page, whitelisted)
+exports.updateIcon = function(page, whitelisted)
{
page.browserAction.setIcon(getIconPath(whitelisted));
whitelistedState.set(page, whitelisted);
-}
-exports.updateIcon = updateIcon;
+};
/**
* Starts to animate the browser action icon to indicate a pending notifcation.
*
* @param {string} type The notification type (i.e: "information" or "critical")
*/
-function startIconAnimation(type)
+exports.startIconAnimation = function(type)
{
notificationType = type;
if (animationInterval == null)
animationInterval = runAnimation();
-}
-exports.startIconAnimation = startIconAnimation;
+};
/**
* Stops to animate the browser action icon.
*/
-function stopIconAnimation()
+exports.stopIconAnimation = function()
{
if (animationInterval != null)
{
@@ -126,5 +124,4 @@
}
notificationType = null;
-}
-exports.stopIconAnimation = stopIconAnimation;
+};
« no previous file with comments | « lib/filterValidation.js ('k') | lib/stats.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld