Issue 2010 - Remove some uses of "for each" with "for of"

chrome/content/ui/sidebar.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 137 matching lines @@
   reloadDisabledScheduled = true;
 }
 
 function reloadDisabledFiltersInternal()
 {
   reloadDisabledScheduled = false;
   disabledMatcher.clear();
 
   if (Prefs.enabled)
   {
-    for each (let subscription in FilterStorage.subscriptions)
+    for (let subscription of FilterStorage.subscriptions)
     {
       if (subscription.disabled)
         continue;
 
-      for each (let filter in subscription.filters)
+      for (let filter of subscription.filters)
         if (filter instanceof RegExpFilter && filter.disabled)
           disabledMatcher.add(filter);
     }
   }
 
   treeView.updateFilters();
 }
 
 // Called whenever list selection changes - triggers flasher
 function onSelectionChange() {
@@ skipping 295 matching lines @@
 
   doBlock();
 }
 
 /**
  * Opens the item in a new tab.
  */
 function openInTab(item, /**Event*/ event)
 {
   let items = (item ? [item] : treeView.getAllSelectedItems());
-  for each (let item in items)
+  for (let item of items)
   {
     if (item && item.typeDescr != "ELEMHIDE")
       UI.loadInBrowser(item.location, mainWin, event);
   }
 }
 
 function doBlock() {
   var item = treeView.getSelectedItem();
   if (!item || item.typeDescr == "ELEMHIDE")
     return;
@@ skipping 175 matching lines @@
   myPrefs.detachsidebar = doDetach;
   myMainWin.document.getElementById("abp-command-sidebar").doCommand();
 }
 
 // Returns items size in the document if available
 function getItemSize(item)
 {
   if (item.filter && !item.filter.disabled && item.filter instanceof BlockingFilter)
     return null;
 
-  for each (let node in item.nodes)
+  for (let node of item.nodes)
   {
     if (node instanceof HTMLImageElement && (node.naturalWidth || node.naturalHeight))
       return [node.naturalWidth, node.naturalHeight];
     else if (node instanceof HTMLElement && (node.offsetWidth || node.offsetHeight))
       return [node.offsetWidth, node.offsetHeight];
   }
   return null;
 }
 
 // Sort functions for the item list
@@ skipping 109 matching lines @@
   setTree: function(boxObject) {
     if (!boxObject)
       return;
     this.boxObject = boxObject;
     this.itemsDummy = boxObject.treeBody.getAttribute("noitemslabel");
     this.whitelistDummy = boxObject.treeBody.getAttribute("whitelistedlabel");
     var stringAtoms = ["col-address", "col-type", "col-filter", "col-state", "col-size", "col-docDomain", "col-filterSource", "state-regular", "state-filtered", "state-whitelisted", "state-hidden", "state-hiddenexception"];
     var boolAtoms = ["selected", "dummy", "filter-disabled"];
     var atomService = Cc["@mozilla.org/atom-service;1"].getService(Ci.nsIAtomService);
     this.atoms = {};
-    for each (let atom in stringAtoms)
+    for (let atom of stringAtoms)
       this.atoms[atom] = atomService.getAtom(atom);
-    for each (let atom in boolAtoms)
+    for (let atom of boolAtoms)
     {
       this.atoms[atom + "-true"] = atomService.getAtom(atom + "-true");
       this.atoms[atom + "-false"] = atomService.getAtom(atom + "-false");
     }
 
     this.itemsDummyTooltip = Utils.getString("no_blocking_suggestions");
     this.whitelistDummyTooltip = Utils.getString("whitelisted_page");
 
     // Check current sort direction
     var cols = document.getElementsByTagName("treecol");
@@ skipping 319 matching lines @@
       this.selection.select(index);
       this.boxObject.ensureRowIsVisible(index);
       this.itemToSelect = null;
     }
     else if (!scanComplete && this.selection.currentIndex >= 0) // Keep selected row visible while scanning
       this.boxObject.ensureRowIsVisible(this.selection.currentIndex);
   },
 
   updateFilters: function()
   {
-    for each (let item in this.allData)
+    for (let item of this.allData)
     {
       if (item.filter instanceof RegExpFilter && item.filter.disabled)
         delete item.filter;
       if (!item.filter)
         item.filter = disabledMatcher.matchesAny(item.location, item.typeDescr, item.docDomain, item.thirdParty);
     }
     this.refilter();
   },
 
   /**
@@ skipping 104 matching lines @@
       return {tooltip: this.itemsDummyTooltip};
   },
 
   invalidateItem: function(item)
   {
     let row = this.data.indexOf(item);
     if (row >= 0)
       this.boxObject.invalidateRow(row);
   }
 }