Issue 1708 - Integrate first-run page changes in Chrome/Opera/Safari

background.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 549 matching lines @@
       break;
     case "forward":
       if (sender.page)
       {
         sender.page.sendMessage(msg.payload, sendResponse);
         // Return true to indicate that we want to call
         // sendResponse asynchronously
         return true;
       }
       break;
-    default:

[Sebastian Noack, 2014/12/19 17:57:53]

We discussed that earlier on IRC. So you made sure this doesn't result in memory
leaks on Safari?

[Wladimir Palant, 2014/12/19 19:38:42]

Not more leaks than what we usually have (see "get-domain-enabled-state"
handler, it doesn't always send a response). As long as every message is handled
there are no memory leaks. And if we have unhandled messages expecting response
and send an empty object there then we have bigger issues than memory leaks.

That said: yes, it seems that our Safari messaging system is prone to memory
leaks. We should solve it the same way Chrome solved it: if the message handler
didn't return true and didn't call the callback then send "there won't be any
response, delete that callback" to the other side. I'd suggest fixing this in a
separate issue however, it's only marginally related.

[Sebastian Noack, 2014/12/19 19:52:00]

Mind filing that issue? :)

[Wladimir Palant, 2014/12/19 20:10:51]

Sure: https://issues.adblockplus.org/ticket/1724

-      sendResponse({});
-      break;
   }
 });
 
 // update icon when page changes location
 ext.pages.onLoading.addListener(function(page)
 {
   page.sendMessage({type: "clickhide-deactivate"});
   refreshIconAndContextMenu(page);
 });
 
 setTimeout(function()
 {
   var notificationToShow = Notification.getNextToShow();
   if (notificationToShow)
     showNotification(notificationToShow);
 }, 3 * 60 * 1000);