Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginFilter.h

Issue 6567422169448448: Issue 119 - Switch to injecting CSS for element hiding (Closed)
Patch Set: rebase, improve memory handling (OnQuit) and improve code organizing Created April 27, 2016, 1:10 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/PluginFilter.h
diff --git a/src/plugin/PluginFilter.h b/src/plugin/PluginFilter.h
index 79a580251ace59c8bd64abaeb482e2f682b3c3bf..c107e2722b6b32baba00a10037c1a8d241e4c92b 100644
--- a/src/plugin/PluginFilter.h
+++ b/src/plugin/PluginFilter.h
@@ -127,8 +127,6 @@ class CPluginFilter
private:
- CString m_dataPath;
-
// (Tag,Name) -> Filter
typedef std::multimap<std::pair<CString,CString>, CFilterElementHide> TFilterElementHideTagsNamed;
@@ -139,16 +137,18 @@ private:
TFilterElementHideTagsNamed m_elementHideTagsId;
TFilterElementHideTagsNamed m_elementHideTagsClass;
TFilterElementHideTags m_elementHideTags;
+ std::vector<std::wstring> m_hideFilters;
- void ClearFilters();
public:
- CPluginFilter(const CString& dataPath = "");
- bool LoadHideFilters(std::vector<std::wstring> filters);
+ explicit CPluginFilter(const std::vector<std::wstring>& filters);
bool AddFilterElementHide(CString filter);
bool IsElementHidden(const std::wstring& tag, IHTMLElement* pEl, const std::wstring& domain, const std::wstring& indent) const;
- HANDLE hideFiltersLoadedEvent;
+ const std::vector<std::wstring>& GetHideFilters() const {
+ return m_hideFilters;
+ }
};
+typedef std::shared_ptr<CPluginFilter> PluginFilterPtr;
#endif // _PLUGIN_FILTER_H_

Powered by Google App Engine
This is Rietveld