Issue 1598 - The set up was unable to automatically close IE while uninstall

installer/src/custom-action/close_application.cpp

 /**
  * \file close_application.cpp
  */
 
 #include <algorithm>
 
 #include "session.h"
 #include "property.h"
 #include "database.h"
 #include "process.h"
@@ skipping 204 matching lines @@
     {
       // Assert installer is running without user interaction.
       interactive = false ;
       if ( state == notKnown )
       {
         // Assert AVOIDREBOOT was not specified
         /*
          * This is where we specify default behavior for non-interactive operation.
          * The choice of "allow" makes it act like other installers, which is to make no effort to avoid a reboot after installation.
          */
-        state = allow ;
-        session.Log( "Reboot allowed by default in non-interactive session." ) ;
+        state = notKnown ;

[Eric, 2015/03/18 16:13:47]

Assigning a state that you just checked is not needed.

But if you want to change the default behavior, the correct state would be
'automatic'. 

The 'notKnown' action in the state machine has a precondition that you're in an
interactive session. This block is guarded by the condition that we're not
interactive, so you've got a logic error if you assign 'notKnown' here.

+        session.Log( "Reboot NOT allowed by default in non-interactive session." ) ;
       }
       else if ( state == active )
       {
         throw std::runtime_error( "AVOIDREBOOT=ACTIVE in non-interative session is not consistent" ) ;
       }
       // Assert state is one of { allow, passive, automatic }
     }
     else
     {
       throw std::runtime_error( "unrecognized value for UILevel" ) ;
@@ skipping 204 matching lines @@
     return ERROR_INSTALL_FAILURE ;
   }
   catch( ... )
   {
     session.LogNoexcept( "terminated by unknown exception" ) ;
     return ERROR_INSTALL_FAILURE ;
   }
   // Should be unreachable.
   return ERROR_INSTALL_FAILURE ;
 }