Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: installer/src/msi/adblockplusie.wxs

Issue 6689082285490176: Issue 1598 - The set up was unable to automatically close IE while uninstall
Patch Set: Created March 18, 2015, 1:42 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: installer/src/msi/adblockplusie.wxs
===================================================================
--- a/installer/src/msi/adblockplusie.wxs
+++ b/installer/src/msi/adblockplusie.wxs
@@ -183,7 +183,7 @@
The 64-bit Close_IE action needs to examine 64-bit processes on the system, which are invisible to 32-bit processes.
-->
<Binary Id="installer_ca" SourceFile="$(var.installer_dir)\build\$(var.build_dir)\$(var.CA_Configuration)\installer-ca.dll"/>
- <InstallUISequence>
+ <InstallExecuteSequence>
Eric 2015/03/18 16:13:47 This doesn't do what you want. The whole point of
<!--
The LaunchConditions action occurs near the beginning, before any of the expensive operations.
-->
@@ -191,7 +191,8 @@
Action="Close_IE"
After="LaunchConditions"
/>
- </InstallUISequence>
+
+ </InstallExecuteSequence>
<!--
We have only a single feature, since there aren't any optional parts.

Powered by Google App Engine
This is Rietveld