chrome/content/survey.xul - Issue 8382011: Applied changes from emailed code review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: chrome/content/survey.xul

Issue 8382011: Applied changes from emailed code review (Closed)

Left Patch Set: Applied remaining changes Created Sept. 26, 2012, 9:02 a.m.

Right Patch Set: Created Sept. 28, 2012, 1:40 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <?xml version="1.0"?>	1 <?xml version="1.0"?>

2	2

3 <!-- This Source Code Form is subject to the terms of the Mozilla Public	3 <!-- This Source Code Form is subject to the terms of the Mozilla Public

4 - License, v. 2.0. If a copy of the MPL was not distributed with this file,	4 - License, v. 2.0. If a copy of the MPL was not distributed with this file,

5 - You can obtain one at http://mozilla.org/MPL/2.0/. -->	5 - You can obtain one at http://mozilla.org/MPL/2.0/. -->

6	6

7 <!DOCTYPE overlay SYSTEM "chrome://url-fixer/locale/survey.dtd">	7 <!DOCTYPE overlay SYSTEM "chrome://url-fixer/locale/survey.dtd">

8 <panel	8 <panel

9 xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"	9 xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"

10 id="url-fixer-survey"	10 id="url-fixer-survey"

11 title="&urlfixer.survey.title;"

12 type="arrow"	11 type="arrow"

13 orient="vertical"	12 orient="vertical"

14 windowtype="urlfixer:survey">	13 windowtype="urlfixer:survey">

	14 <description id="url-fixer-title">&urlfixer.survey.title;</description>

15 <hbox>	15 <hbox>

16 <vbox>	16 <vbox>

17 <image id="icon"/>	17 <image id="url-fixer-icon"/>
Wladimir Palant 2012/09/28 09:29:34 You are adding this to a large document updated by You are adding this to a large document updated by a third party and with content being added by other third parties (extensions). And IDs have to be unique document-wide. So you just cannot use any generic IDs. Something like "url-fixer-icon" should do however (and similarly everywhere else).
18 </vbox>	18 </vbox>

19 <vbox id="question_container" pack="center">	19 <vbox id="url-fixer-question_container" pack="center">

20 <description id="question">&urlfixer.survey.question;</description>	20 <description id="url-fixer-question">&urlfixer.survey.question;</descripti on>

21 <description>&urlfixer.survey.note;</description>	21 <description>&urlfixer.survey.note;</description>

22 </vbox>	22 </vbox>

23 </hbox>	23 </hbox>

24 <hbox id="actions">	24 <hbox id="url-fixer-actions" pack="end">

25 <space flex="1"/>	25 <button id="url-fixer-accept-button">&urlfixer.survey.accept;</button>
Wladimir Palant 2012/09/28 09:29:34 You probably meant <spacer>. Either way, just add You probably meant <spacer>. Either way, just add pack="end" attribute on the <hbox>, this will be sufficient.
26 <button id="accept-button" dlgtype="accept">&urlfixer.survey.accept;</button >	26 <button id="url-fixer-cancel-button">&urlfixer.survey.decline;</button>

27 <button id="cancel-button" dlgtype="cancel">&urlfixer.survey.decline;</butto n>
Wladimir Palant 2012/09/28 09:29:34 dlgtype attribute only makes sense in dialogs. dlgtype attribute only makes sense in dialogs.
28 </hbox>	27 </hbox>

29 </panel>	28 </panel>

LEFT	RIGHT