Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/options.xul

Issue 8382011: Applied changes from emailed code review (Closed)
Patch Set: Created Sept. 18, 2012, 2:06 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/content/options.xul
===================================================================
--- a/chrome/content/options.xul
+++ b/chrome/content/options.xul
@@ -36,7 +36,7 @@
</listcols>
</listbox>
<hbox>
- <button flex="1" label="&urlfixer.options.removeButtonLabel;" onclick="removeRule(this);" disabled="true" id="whitelist_remove-button" _list="whitelist" />
+ <button flex="1" label="&urlfixer.options.removeButtonLabel;" onclick="removeRule(this,'whitelist');" disabled="true" id="whitelist_remove-button" _list="whitelist" />
</hbox>
</tabpanel>
<tabpanel orient="vertical">
@@ -47,7 +47,7 @@
<hbox>
<button flex="1" label="&urlfixer.options.addButtonLabel;" oncommand="addRule();" id="add-button" disabled="true" />
</hbox>
- <description>&urlfixer.options.regularExpressionExplanation;</description>
+ <description id="custom_corrections-explanation">&urlfixer.options.regularExpressionExplanation;</description>
<listbox id="custom_corrections" flex="1" seltype="multiple" onselect="onItemSelected(this);" _removeButton="custom_corrections_remove-button" _emptyLabel="&urlfixer.options.findAndReplaceEmptyLabel;">
<listhead>
<listheader label="&urlfixer.options.findLabel;"/>
@@ -59,7 +59,7 @@
</listcols>
</listbox>
<hbox>
- <button flex="1" label="&urlfixer.options.removeButtonLabel;" onclick="removeRule(this);" disabled="true" id="custom_corrections_remove-button" _list="custom_corrections" />
+ <button flex="1" label="&urlfixer.options.removeButtonLabel;" onclick="removeRule(this,'custom_replace');" disabled="true" id="custom_corrections_remove-button" _list="custom_corrections" />
</hbox>
</tabpanel>
</tabpanels>

Powered by Google App Engine
This is Rietveld